From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Paul Durrant <paul@xen.org>
Subject: Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment
Date: Fri, 4 Oct 2019 14:18:29 +0100 [thread overview]
Message-ID: <c694e8f7-fd64-f2be-fadb-edc1478d07ae@citrix.com> (raw)
In-Reply-To: <dc7d25e5-11f8-b6c3-7137-ceb0814e836a@suse.com>
On 26/09/2019 15:28, Jan Beulich wrote:
> @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st
> IOMMU_PPR_LOG_DEFAULT_ENTRIES, "PPR Log");
> }
>
> +/*
> + * Within ivrs_mappings[] we allocate an extra array element to store
> + * - segment number,
> + * - device table.
> + */
> +#define IVRS_MAPPINGS_SEG(m) (m)[ivrs_bdf_entries].dte_requestor_id
> +#define IVRS_MAPPINGS_DEVTAB(m) (m)[ivrs_bdf_entries].intremap_table
> +
> +static void __init free_ivrs_mapping(void *ptr)
> +{
> + const struct ivrs_mappings *ivrs_mappings = ptr;
How absolutely certain are we that ptr will never be NULL?
It might be better to rename this to radix_tree_free_ivrs_mappings() to
make it clear who calls it, and also provide a hint as to why the
parameter is void.
> +
> + if ( IVRS_MAPPINGS_DEVTAB(ivrs_mappings) )
> + deallocate_buffer(IVRS_MAPPINGS_DEVTAB(ivrs_mappings),
> + dt_alloc_size());
> +
> + xfree(ptr);
> +}
> +
> static int __init amd_iommu_init_one(struct amd_iommu *iommu, bool intr)
> {
> + const struct ivrs_mappings *ivrs_mappings;
> +
> if ( allocate_cmd_buffer(iommu) == NULL )
> goto error_out;
>
> @@ -1082,13 +1102,15 @@ static int __init amd_iommu_init_one(str
> if ( intr && !set_iommu_interrupt_handler(iommu) )
> goto error_out;
>
> - /* To make sure that device_table.buffer has been successfully allocated */
> - if ( device_table.buffer == NULL )
> + /* Make sure that the device table has been successfully allocated. */
> + ivrs_mappings = get_ivrs_mappings(iommu->seg);
> + if ( !IVRS_MAPPINGS_DEVTAB(ivrs_mappings) )
This is still going to crash with a NULL pointer deference in the case
described by the comment. (Then again, it may not crash, and hit
userspace at the 64M mark.)
You absolutely need to check ivrs_mappings being non NULL before using
IVRS_MAPPINGS_DEVTAB(), or perhaps roll the check into the macro.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-04 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 14:26 [Xen-devel] [PATCH v7 0/3] AMD IOMMU: further improvements Jan Beulich
2019-09-26 14:28 ` [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment Jan Beulich
2019-10-04 13:18 ` Andrew Cooper [this message]
2019-10-04 13:30 ` Jan Beulich
2019-10-04 17:28 ` Andrew Cooper
2019-10-07 10:03 ` Jan Beulich
2019-10-07 10:19 ` Jürgen Groß
2019-10-07 10:49 ` Jan Beulich
2019-10-07 11:25 ` Jürgen Groß
2019-10-10 5:57 ` Jan Beulich
2019-10-10 6:12 ` Jürgen Groß
2019-09-26 14:29 ` [Xen-devel] [PATCH v7 2/3] AMD/IOMMU: allow callers to request allocate_buffer() to skip its memset() Jan Beulich
2019-10-04 13:26 ` Andrew Cooper
2019-10-04 13:33 ` Jan Beulich
2019-09-26 14:29 ` [Xen-devel] [PATCH v7 3/3] AMD/IOMMU: pre-fill all DTEs right after table allocation Jan Beulich
2019-10-04 13:43 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c694e8f7-fd64-f2be-fadb-edc1478d07ae@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).