From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDF1C433ED for ; Thu, 1 Apr 2021 16:02:43 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C05D6112E for ; Thu, 1 Apr 2021 16:02:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C05D6112E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.104628.200352 (Exim 4.92) (envelope-from ) id 1lRzm6-0007HT-UD; Thu, 01 Apr 2021 16:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 104628.200352; Thu, 01 Apr 2021 16:02:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzm6-0007HM-R3; Thu, 01 Apr 2021 16:02:26 +0000 Received: by outflank-mailman (input) for mailman id 104628; Thu, 01 Apr 2021 16:02:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzm6-0007HH-9R for xen-devel@lists.xenproject.org; Thu, 01 Apr 2021 16:02:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRzm4-0001OQ-KH; Thu, 01 Apr 2021 16:02:24 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRzm4-0000Gr-CV; Thu, 01 Apr 2021 16:02:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Sv8RS+0wdbIiWMwwTW7Y/bRZsDmFGVjABoKk8ZFtJ9Y=; b=pe0YJGhRcxIzxEGjv0rYVUehP0 /d9RRrQ9nap11zTZFzUV2qvQiPPFCdgegruEUrkR5W2rpiZ2SbgJZYa0AbeW4ImDtbWe7gxZjbA4x TDe4HZIyn012wPMu1tMUOAZ9wzFKVxKz2uMYhqAKv1BWEN0fD2+TOzU3i1AXclGKVz9E=; Subject: Re: [PATCH v2 1/2] common: map_vcpu_info() cosmetics To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , Stefano Stabellini References: <2a08aa31-fdbf-89ee-cd49-813f818b709a@suse.com> <29514f9a-b630-f66e-286e-8b73fcf4d58a@suse.com> From: Julien Grall Message-ID: Date: Thu, 1 Apr 2021 17:02:22 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <29514f9a-b630-f66e-286e-8b73fcf4d58a@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Jan, On 22/12/2020 08:14, Jan Beulich wrote: > Use ENXIO instead of EINVAL to cover the two cases of the address not > satisfying the requirements. This will make an issue here better stand > out at the call site. > > Also add a missing compat-mode related size check: If the sizes > differed, other code in the function would need changing. Accompany this > by a change to the initial sizeof() expression, tying it to the type of > the variable we're actually after (matching e.g. the alignof() added by > XSA-327). > > Signed-off-by: Jan Beulich > Reviewed-by: Roger Pau Monné Acked-by: Julien Grall Cheers, -- Julien Grall