xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Olaf Hering <olaf@aepfle.de>, <xen-devel@lists.xenproject.org>
Cc: "Ian Jackson" <iwj@xenproject.org>, "Wei Liu" <wl@xen.org>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD
Date: Tue, 4 May 2021 18:47:12 +0100	[thread overview]
Message-ID: <c71658e6-422b-4852-6d21-4688d09d8b8e@citrix.com> (raw)
In-Reply-To: <20210504135021.8394-1-olaf@aepfle.de>

On 04/05/2021 14:50, Olaf Hering wrote:
> --log does not take a file, it specifies what is supposed to be logged.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>.  That said, ...

> ---
>  tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> index ccd5a9b055..36dd717944 100644
> --- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
> +++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> @@ -23,7 +23,7 @@ required_files="/dev/xen/xenstored"
>  
>  XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
>  XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
> -#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
> +#XENCONSOLED_TRACE="none|guest|hv|all"
>  #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"

It would probably be clearer to untangle these in one go, leaving the
result looking like:

XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
#XENCONSOLED_TRACE="none|guest|hv|all"

XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
#XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"

I'd also be tempted to fold this and the NetBSD change together.  It's
not as if these bugfixes are distro-specific.


It looks like a bug in NetBSD in c/s 2e8644e1d90, which was copied into
FreeBSD by c/s 5dcdb2bf569.  (P.S. Sorry Roger - both your bugs,
starting from a decade ago).  It really is idiotic that we've got a
commonly named *_TRACE variable with totally different semantics for the
two daemons.  Then again, its far too late to fix this :(

~Andrew



  reply	other threads:[~2021-05-04 17:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 13:50 [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD Olaf Hering
2021-05-04 17:47 ` Andrew Cooper [this message]
2021-05-06 14:36   ` Olaf Hering
2021-05-07  7:25   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c71658e6-422b-4852-6d21-4688d09d8b8e@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=olaf@aepfle.de \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).