Re: [PATCH 0/2] Dangling fixes for ARM iommu

[Julien Grall <julien.grall@arm.com>]

(+ Juergen)

On 21/01/2019 17:04, Andrii Anisov wrote:
> From: Andrii Anisov <andrii_anisov@epam.com>
> 
> Dear All,

Hello,

All patches candidate for Xen 4.12 should have the release manager CCed and 
explain the pros/cons to have those patches for this release. It is also useful 
if you add for-4.12 (or similar) in the [...] so we can prioritize it.

> 
> With moving our working setup to 4.12-rc2 (IPMMU series especially),I've
> realized that we have a couple of patches from IPMMU series [1] which are
> fixes, got RB/AB, but not reached mainline yet. I really hope those RB/AB
> would not be treated as stale, and patches are OK to go into 4.12 release.

Firstly, the RB tag means the reviewer reviewed the patch in depth with the code 
base at that time. So I don't think the RBs should have been carried from a 
patch series sent 2 years ago. Indeed code base evolved, for instance 
iommu_use_hap_pt has a slight different behavior now.

So please stripped my RB. The AB is arguable as it is quite old.

Secondly, it often happens that some patches have the required acked-by and 
reviewed-by but are not merged because they makes little sense without the rest 
of the series. In that case, the current code base does not support the case 
where the P2M is not shared with the IOMMU and does not support new IOMMU 
bindings in the current setup.

So I am not convinced they should be included in Xen 4.12 or even without the 
rest of the series.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel