From: Julien Grall <julien.grall@arm.com>
To: Viktor Mitin <viktor.mitin.19@gmail.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, Viktor Mitin <viktor_mitin@epam.com>
Subject: Re: [Xen-devel] [PATCH] xen/arm: remove unused dt_device_node parameter
Date: Sun, 7 Jul 2019 18:29:25 +0100 [thread overview]
Message-ID: <c9fd6e90-e5bc-0665-4c46-9c86ad0511a2@arm.com> (raw)
In-Reply-To: <20190618085851.22902-1-viktor.mitin.19@gmail.com>
Hi Viktor,
On 6/18/19 9:58 AM, Viktor Mitin wrote:
> Some of the function generating nodes (e.g make_timer_node)
> take in a dt_device_node parameter, but never used it.
> It is actually misused when creating DT for DomU.
> So it is the best to remove the parameter.
>
> Suggested-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Viktor Mitin <viktor_mitin@epam.com>
Reviewed-by: Julien Grall <julien.grall@arm.com>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-08 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 8:58 [Xen-devel] [PATCH] xen/arm: remove unused dt_device_node parameter Viktor Mitin
2019-07-07 17:29 ` Julien Grall [this message]
2019-07-18 13:18 ` Viktor Mitin
2019-07-23 12:10 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9fd6e90-e5bc-0665-4c46-9c86ad0511a2@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=viktor.mitin.19@gmail.com \
--cc=viktor_mitin@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).