From: "Jürgen Groß" <jgross@suse.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Sergei Temerkhanov <s.temerkhanov@gmail.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data
Date: Tue, 25 Aug 2020 15:49:34 +0200 [thread overview]
Message-ID: <cb64e4e9-2ed3-fb15-8c20-d49e47cbff34@suse.com> (raw)
In-Reply-To: <87k0xn5cgl.fsf@nanos.tec.linutronix.de>
On 25.08.20 10:58, Thomas Gleixner wrote:
> On Mon, Aug 24 2020 at 20:14, Stefano Stabellini wrote:
>> On Fri, 21 Aug 2020, Thomas Gleixner wrote:
>>> are accessors to handler_data. Am I missing something?
>> I think Juergen's suggestion was to use function pointers as accessors.
>>
>> The underlying problem is that both Xen and GPIO want to use
>> handler_data.
>>
>> Xen comes first and uses handler_data to handle Xen events
>> (drivers/xen/events/events_base.c:xen_irq_init).
>>
>> Then, the GPIO driver probe function
>> (drivers/pinctrl/intel/pinctrl-baytrail.c:byt_gpio_probe) calls
>> gpiochip_set_chained_irqchip, which eventually calls
>> irq_set_chained_handler_and_data, overwriting handler_data without
>> checks.
>>
>> Juergen's suggestion is to replace irq_set_handler_data and
>> irq_get_handler_data with function pointers.
>>
>> Xen could install its own irq_set_handler_data and irq_get_handler_data
>> functions. The Xen implementation would take care of saving other
>> handler_data pointers on request: when the GPIO driver calls
>> irq_set_chained_handler_and_data it would end up calling the Xen
>> implementation of the set_handler_data function that would store the
>> GPIO pointer in a Xen struct somewhere.
>
> I don't think that's a good idea. The point is that we have an irq chip
> which wants to have per interrupt data and then an interrupt request
> which wants that as well.
>
> Conceptually they are distinct. One belongs to the irq chip and one to
> the handler.
>
> So the straight forward solution is to switch XEN to use the
> irqdesc::irq_data::chip_data instead of
> irqdesc::irq_data_common::handler_data.
Of course. I must have been blind not to spot chip_data to exist.
>
> Something like the completely untested below.
A short test showed no problems. Would you mind sending it as a proper
patch? You can add my
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
>
> Thanks,
>
> tglx
> ---
> drivers/xen/events/events_base.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -156,7 +156,7 @@ int get_evtchn_to_irq(evtchn_port_t evtc
> /* Get info for IRQ */
> struct irq_info *info_for_irq(unsigned irq)
> {
> - return irq_get_handler_data(irq);
> + return irq_get_chip_data(irq);
> }
>
> /* Constructors for packed IRQ information. */
> @@ -377,7 +377,7 @@ static void xen_irq_init(unsigned irq)
> info->type = IRQT_UNBOUND;
> info->refcnt = -1;
>
> - irq_set_handler_data(irq, info);
> + irq_set_chip_data(irq, info);
>
> list_add_tail(&info->list, &xen_irq_list_head);
> }
> @@ -426,14 +426,14 @@ static int __must_check xen_allocate_irq
>
> static void xen_free_irq(unsigned irq)
> {
> - struct irq_info *info = irq_get_handler_data(irq);
> + struct irq_info *info = irq_get_chip_data(irq);
>
> if (WARN_ON(!info))
> return;
>
> list_del(&info->list);
>
> - irq_set_handler_data(irq, NULL);
> + irq_set_chip_data(irq, NULL);
>
> WARN_ON(info->refcnt > 0);
>
> @@ -603,7 +603,7 @@ EXPORT_SYMBOL_GPL(xen_irq_from_gsi);
> static void __unbind_from_irq(unsigned int irq)
> {
> evtchn_port_t evtchn = evtchn_from_irq(irq);
> - struct irq_info *info = irq_get_handler_data(irq);
> + struct irq_info *info = irq_get_chip_data(irq);
>
> if (info->refcnt > 0) {
> info->refcnt--;
> @@ -1108,7 +1108,7 @@ int bind_ipi_to_irqhandler(enum ipi_vect
>
> void unbind_from_irqhandler(unsigned int irq, void *dev_id)
> {
> - struct irq_info *info = irq_get_handler_data(irq);
> + struct irq_info *info = irq_get_chip_data(irq);
>
> if (WARN_ON(!info))
> return;
> @@ -1142,7 +1142,7 @@ int evtchn_make_refcounted(evtchn_port_t
> if (irq == -1)
> return -ENOENT;
>
> - info = irq_get_handler_data(irq);
> + info = irq_get_chip_data(irq);
>
> if (!info)
> return -ENOENT;
> @@ -1170,7 +1170,7 @@ int evtchn_get(evtchn_port_t evtchn)
> if (irq == -1)
> goto done;
>
> - info = irq_get_handler_data(irq);
> + info = irq_get_chip_data(irq);
>
> if (!info)
> goto done;
>
next prev parent reply other threads:[~2020-08-25 13:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 22:09 Xen 4.14.0 is busted on Dell 300x IoT Gateways Roman Shaposhnik
2020-08-18 22:20 ` Andrew Cooper
2020-08-18 22:34 ` Roman Shaposhnik
2020-08-21 1:39 ` Stefano Stabellini
2020-08-21 7:15 ` [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data Sergey Temerkhanov
2020-08-21 7:15 ` [PATCH 1/2] Xen: Use a dedicated irq_info structure pointer Sergey Temerkhanov
2020-08-21 7:15 ` [PATCH 2/2] Xen: Rename irq_info structure Sergey Temerkhanov
2020-08-21 10:18 ` [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data Jürgen Groß
2020-08-21 11:19 ` Sergei Temerkhanov
2020-08-21 12:17 ` Jürgen Groß
2020-08-21 20:07 ` Thomas Gleixner
2020-08-21 20:38 ` Sergei Temerkhanov
2020-08-22 0:16 ` Thomas Gleixner
2020-08-25 3:14 ` Stefano Stabellini
2020-08-25 8:58 ` Thomas Gleixner
2020-08-25 13:49 ` Jürgen Groß [this message]
2020-08-25 15:22 ` [PATCH] xen/events: Use chip data for storing per IRQ XEN data pointer, Thomas Gleixner
2020-08-25 15:43 ` [PATCH] xen/events: Use chip data for storing per IRQ XEN data pointer Jürgen Groß
2020-08-25 22:04 ` Roman Shaposhnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb64e4e9-2ed3-fb15-8c20-d49e47cbff34@suse.com \
--to=jgross@suse.com \
--cc=s.temerkhanov@gmail.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).