From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20486C433E1 for ; Tue, 18 Aug 2020 12:40:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC2B4206B5 for ; Tue, 18 Aug 2020 12:40:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="MDEHFEpv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC2B4206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k80ug-0001wG-Md; Tue, 18 Aug 2020 12:40:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k80uf-0001wB-3f for xen-devel@lists.xenproject.org; Tue, 18 Aug 2020 12:40:25 +0000 X-Inumbo-ID: 474d6a36-5dd8-45d3-b2f3-78ce3d3d0b27 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 474d6a36-5dd8-45d3-b2f3-78ce3d3d0b27; Tue, 18 Aug 2020 12:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597754423; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=jGhNuXZWs6l5vILHVgLNpgCN/EgznOx2kpLZQgHamCc=; b=MDEHFEpvFp6Gdzs6ppNGB7ESwBjgdU/S+3YUysKl865911wT34AnUH4M gUfv1Zpp3jL4pBJ656+sePZh9XJEpo9MIEw83AV4EQx6uvcSxWQ+DZ+Ya 7gzWrZvfngyfnPWHO7t+EHMNZ+puQYocsTjRFN9SHsucNMpt+6cTPiZJL A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Wn2tfHIJ7FEaxMb7GdsleuEyCSYi9fUEd5LNe1oYqwBiKG2L//yzbKG5tZx+l9/Vteryx2QBBQ 8B8Da5xf9ZCIbHU2KwAMT4Qr5tr25EZU4lPXbaBTdJWRXHD+h9ZK2vUYOtxVydSto7WgiUSRPw MN3i/wUPNdPKono3DCnVGnB0W7uSu2Xj005/YMUE4NHONdK8Vw1W5Hr8DIgsaJFBFUEM38Zb+E G8cnH1OWH/8aEB23ieO9Prr0PJAl3nFicIyicnlJl/ucJ9XnCYq3gsdr2IqEpBcwrM2+O//qj0 Fk8= X-SBRS: 2.7 X-MesageID: 25689174 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,327,1592884800"; d="scan'208";a="25689174" Subject: Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code To: Christian Lindig , Edwin Torok , "xen-devel@lists.xenproject.org" CC: Ian Jackson , "dave@recoil.org" , "wl@xen.org" References: <1597668966374.91968@citrix.com> <1597742707142.74318@citrix.com> From: Andrew Cooper Message-ID: Date: Tue, 18 Aug 2020 13:40:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1597742707142.74318@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 18/08/2020 10:25, Christian Lindig wrote: > I see little reason to support old OCaml releases and requiring OCaml 4.06 would be fine with me but I assume that the project might have its own ideas about this. > > ________________________________________ > From: Edwin Torok > Sent: 18 August 2020 08:28 > To: Christian Lindig; xen-devel@lists.xenproject.org > Cc: Ian Jackson; dave@recoil.org; wl@xen.org > Subject: Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code > > On Mon, 2020-08-17 at 14:56 +0200, Christian Lindig wrote: >> This all looks good - I left a small comment on one of the patches >> and I agree that this needs testing. I also wonder about >> compatibility with earlier OCaml releases that we support but I see >> no real obstacles. >> > I've developed the series using OCaml 4.08.1. I think the newest > feature I used was Map.update (OCaml 4.06, nearly 3 years ago). > Looking through https://repology.org/project/ocaml/versions I'm not > sure if we can require more than 4.05 though. > The README in Xen doesn't specify a minimum version, but configure > checks for >=4.02. > > I can try to backport my series to OCaml 4.05 (to use Map.find_opt > instead of Map.update) and update the configure check to require 4.05. > It would be possible to backport even further to 4.02 by introducing > additional inefficiencies (Map.mem + Map.find would traverse the map > twice, and Map.find on its own would raise an exception on Not found, > which is more costly than returning None in Map.find_opt), I'd avoid > doing that. > > Xen's CI from automation might need some updates to use latest stable > versions: > * Fedora 29 is EOL, should use at least Fedora 31 > * Debian Jessie is EOL. Stretch is present, but Buster is missing We're working on the CI loop. As maintainer, it is ultimately Christian's choice to as to if/when to bump the minimum versions. As a general rule, we don't want to be sufficiently bleeding edge to rule out in-use distros.  I have no idea if 4.06 is ok there, or whether it is too new.  Then again, the Ocaml components are strictly optional so it is perhaps less important. Whatever happens WRT version, the configure change should occur before changes in the code which would fail on older versions. ~Andrew