From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAB08C433B4 for ; Mon, 10 May 2021 11:56:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E0A260E09 for ; Mon, 10 May 2021 11:56:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E0A260E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.125163.235618 (Exim 4.92) (envelope-from ) id 1lg4WP-000323-KC; Mon, 10 May 2021 11:56:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 125163.235618; Mon, 10 May 2021 11:56:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lg4WP-00031w-Gh; Mon, 10 May 2021 11:56:25 +0000 Received: by outflank-mailman (input) for mailman id 125163; Mon, 10 May 2021 11:56:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lg4WN-00031q-WB for xen-devel@lists.xenproject.org; Mon, 10 May 2021 11:56:24 +0000 Received: from mail-qv1-xf34.google.com (unknown [2607:f8b0:4864:20::f34]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5c72902f-f07f-4719-9f16-0f1c82fe520f; Mon, 10 May 2021 11:56:23 +0000 (UTC) Received: by mail-qv1-xf34.google.com with SMTP id u7so8092347qvv.12 for ; Mon, 10 May 2021 04:56:23 -0700 (PDT) Received: from [10.10.1.24] (static-72-81-132-2.bltmmd.fios.verizon.net. [72.81.132.2]) by smtp.gmail.com with ESMTPSA id 67sm11525758qtf.54.2021.05.10.04.56.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 04:56:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c72902f-f07f-4719-9f16-0f1c82fe520f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XCJVmYNyrM3q94U5z333NtN42F/p27BnwTSwO1Xl7Cg=; b=VTgmozNTHdgjFRff9DtYHbWdGehM00zvo/G+1WYdb1tJ8x4D2AqqOCbKgL1CbDbNYL ckbCCwYgmrSNJ9c/aKzAwdLs+4vb8cWcNLfLnAHeg4XdBsL70Vlk66lGK9z6Lzl7XJWd 6yfnv49ikG7KuRLtAEBWJpeqj5Ke+23vgvj7VRFDJh9eLkKibI+vTt5fLpR5DLi7qLQN y4Yg/W8ud4LBM3j9XK2/yd1u/TlFncbP82vbRnvaPMUparsstTfNnTwwg1Evhm+A/IRY 2VKchEJQLVUzU88DOhWq0hqHJHXBv+2EHtmE/BVn/D/iLQBZlRbmaA96vTx3yaJ/9nWZ qZ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XCJVmYNyrM3q94U5z333NtN42F/p27BnwTSwO1Xl7Cg=; b=o+eKDksTENLlifv+0wR3GXPwEFj8UrF7PgMBLBezjB/3DwdDqpbnkLSGZgbZmHTriy EKUhRMNP9Reb5SjARHhkSQ9IY8FYt5d9KKUJlBB3nLIo2QtC8AYTe4qtBV1K6GqE1U8F 0Rd9c2zW60ZBW+UKgU5BHHZZUQAefK0OTuRYaYw8VDVZ88/jjVzgQP9DaNV8N4P5SBC+ ob8lGddihbRZg85O0px3TiwOszo56K8WtExBb638frErL3awt3rswP4L+UtvVKb3+fAw rL6e6iaFnH9UXvPfrTPB2bNBL/syeyimtbEgYgqfCacyw7vwiKZ0u8IdP1iGB/weDF2X O3lQ== X-Gm-Message-State: AOAM530IqwgT2rc9TmJzYfDjMNdFotryhPBZ67w1wzD05/ov64+6P61a o/3IT5l5Rx97I2guastaYZs= X-Google-Smtp-Source: ABdhPJytltMqMo/fhsJ+XFRv+wIo5w4SlzRQ5N6/2CxX5I6ZFrmXNACqm0byydhRNeIcgU6k+NRVtw== X-Received: by 2002:a05:6214:62a:: with SMTP id a10mr22842521qvx.5.1620647782834; Mon, 10 May 2021 04:56:22 -0700 (PDT) Subject: Re: [PATCH v2 04/13] vtpmmgr: Allow specifying srk_handle for TPM2 To: Jason Andryuk , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Daniel De Graaf , Quan Xu , Samuel Thibault References: <20210506135923.161427-1-jandryuk@gmail.com> <20210506135923.161427-5-jandryuk@gmail.com> From: "Daniel P. Smith" Message-ID: Date: Mon, 10 May 2021 07:56:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210506135923.161427-5-jandryuk@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/6/21 9:59 AM, Jason Andryuk wrote: > Bypass taking ownership of the TPM2 if an srk_handle is specified. > > This srk_handle must be usable with Null auth for the time being. > > Signed-off-by: Jason Andryuk > --- Reviewed-by: Daniel P. Smith > v2: Use "=" seperator > --- > docs/man/xen-vtpmmgr.7.pod | 7 +++++++ > stubdom/vtpmmgr/init.c | 11 ++++++++++- > 2 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/docs/man/xen-vtpmmgr.7.pod b/docs/man/xen-vtpmmgr.7.pod > index 875dcce508..3286954568 100644 > --- a/docs/man/xen-vtpmmgr.7.pod > +++ b/docs/man/xen-vtpmmgr.7.pod > @@ -92,6 +92,13 @@ Valid arguments: > > =over 4 > > +=item srk_handle= > + > +Specify a srk_handle for TPM 2.0. TPM 2.0 uses a key hierarchy, and > +this allow specifying the parent handle for vtpmmgr to create its own > +key under. Using this option bypasses vtpmmgr trying to take ownership > +of the TPM. > + > =item owner_auth= > > =item srk_auth= > diff --git a/stubdom/vtpmmgr/init.c b/stubdom/vtpmmgr/init.c > index 1506735051..130e4f4bf6 100644 > --- a/stubdom/vtpmmgr/init.c > +++ b/stubdom/vtpmmgr/init.c > @@ -302,6 +302,11 @@ int parse_cmdline_opts(int argc, char** argv, struct Opts* opts) > goto err_invalid; > } > } > + else if(!strncmp(argv[i], "srk_handle=", 11)) { > + if(sscanf(argv[i] + 11, "%x", &vtpm_globals.srk_handle) != 1) { > + goto err_invalid; > + } > + } > else if(!strncmp(argv[i], "tpmdriver=", 10)) { > if(!strcmp(argv[i] + 10, "tpm_tis")) { > opts->tpmdriver = TPMDRV_TPM_TIS; > @@ -586,7 +591,11 @@ TPM_RESULT vtpmmgr2_create(void) > { > TPM_RESULT status = TPM_SUCCESS; > > - TPMTRYRETURN(tpm2_take_ownership()); > + if ( vtpm_globals.srk_handle == 0 ) { > + TPMTRYRETURN(tpm2_take_ownership()); > + } else { > + tpm2_AuthArea_ctor(NULL, 0, &vtpm_globals.srk_auth_area); > + } > > /* create SK */ > TPM2_Create_Params_out out; >