From: "Jürgen Groß" <jgross@suse.com>
To: Manuel Bouyer <bouyer@antioche.eu.org>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>,
Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xenstored: close socket connections on error
Date: Thu, 4 Feb 2021 12:18:00 +0100 [thread overview]
Message-ID: <cda25726-9942-c0ca-f60f-65681003a4fc@suse.com> (raw)
In-Reply-To: <20210204111613.GA2316@antioche.eu.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 956 bytes --]
On 04.02.21 12:16, Manuel Bouyer wrote:
> On Thu, Feb 04, 2021 at 12:11:02PM +0100, Jürgen Groß wrote:
>> On 03.02.21 17:54, Manuel Bouyer wrote:
>>> On error, don't keep socket connection in ignored state but close them.
>>> When the remote end of a socket is closed, xenstored will flag it as an
>>> error and switch the connection to ignored. But on some OSes (e.g.
>>> NetBSD), poll(2) will return only POLLIN in this case, so sockets in ignored
>>> state will stay open forever in xenstored (and it will loop with CPU 100%
>>> busy).
>>>
>>> Signed-off-by: Manuel Bouyer <bouyer@netbsd.org>
>>> Fixes: d2fa370d3ef9cbe22d7256c608671cdcdf6e0083
>>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
>
> thanks.
> I still don't know if I'm supposed to send a new version of the patch with
> these tags, even if the patch itself doesn't change, or if the commiter
> will handle them ?
>
Will be done by the committer.
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-02-04 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 16:54 [PATCH] add a qemu-ifup script on NetBSD Manuel Bouyer
2021-02-03 16:54 ` [PATCH] xenstored: close socket connections on error Manuel Bouyer
2021-02-03 17:24 ` Ian Jackson
2021-02-03 17:38 ` Ian Jackson
2021-02-03 17:48 ` Manuel Bouyer
2021-02-04 11:11 ` Jürgen Groß
2021-02-04 11:16 ` Manuel Bouyer
2021-02-04 11:18 ` Jürgen Groß [this message]
2021-02-04 11:42 ` Ian Jackson
2021-02-03 16:54 ` [PATCH v3] Document qemu-ifup on NetBSD Manuel Bouyer
2021-02-03 16:54 ` [PATCH v3] NetBSD: use system-provided headers Manuel Bouyer
2021-02-03 17:26 ` Ian Jackson
2021-02-03 18:27 ` Roger Pau Monné
2021-02-03 17:19 ` [PATCH] add a qemu-ifup script on NetBSD Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cda25726-9942-c0ca-f60f-65681003a4fc@suse.com \
--to=jgross@suse.com \
--cc=bouyer@antioche.eu.org \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).