Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Stewart Hildebrand <stewart.hildebrand@dornerworks.com>,
	xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH] xen/arm: platform: additional Raspberry Pi compatible string
Date: Fri, 13 Sep 2019 22:42:24 +0100
Message-ID: <cdff00f6-be00-0b9a-924f-d3c6ffd84a22@arm.com> (raw)
In-Reply-To: <20190913191147.2323-1-stewart.hildebrand@dornerworks.com>

Hi,

On 9/13/19 8:11 PM, Stewart Hildebrand wrote:
> Upstream Linux kernel will use "brcm,bcm2711" as the compatible string
> for Raspberry Pi 4 [1]. Add this string to our platform compatible list
> for compatibility with the upstream kernel.

This raises a few questions:
    1) Why such discrepancies in naming?
    2) Is the patch [1] merged? If so, which version?
    3) Both upstream and non-upstream seem to have the compatible 
"raspberrypi,4-model-b", so would it make sense to check that instead?

> 
> [1] https://patchwork.kernel.org/patch/11092621/
> 
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
> ---
>   xen/arch/arm/platforms/brcm-raspberry-pi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c b/xen/arch/arm/platforms/brcm-raspberry-pi.c
> index e22d2b3184..a95a3db83f 100644
> --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c
> +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c
> @@ -21,6 +21,7 @@
>   
>   static const char *const brcm_bcm2838_dt_compat[] __initconst =
>   {
> +    "brcm,bcm2711",

If a new compatible is added, then you likely need to rename the 
different structure within this file.

>       "brcm,bcm2838",
>       NULL
>   };
> 

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 19:11 Stewart Hildebrand
2019-09-13 21:42 ` Julien Grall [this message]
2019-09-14  1:22   ` Stewart Hildebrand
2019-09-17 11:05     ` Julien Grall
2019-10-04  0:47       ` Stewart Hildebrand

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdff00f6-be00-0b9a-924f-d3c6ffd84a22@arm.com \
    --to=julien.grall@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=stewart.hildebrand@dornerworks.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org xen-devel@archiver.kernel.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox