From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C09C433E1 for ; Thu, 6 Aug 2020 12:01:42 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A2AC22D02 for ; Thu, 6 Aug 2020 12:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="p87upvN7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A2AC22D02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eBn-0006PS-Lm; Thu, 06 Aug 2020 11:36:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eBm-0006PL-7n for xen-devel@lists.xenproject.org; Thu, 06 Aug 2020 11:36:02 +0000 X-Inumbo-ID: f9a4220f-4b5b-4088-86bb-f3b9e75aa515 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f9a4220f-4b5b-4088-86bb-f3b9e75aa515; Thu, 06 Aug 2020 11:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8iWgTxKYT/IHAOXP87qxT1QL7H18LTKdd2MXZH7yLDU=; b=p87upvN7VG2RgeRFxEmi28tYIi UYhl1xhvJH0pW+GJz40TESgDyBBzNLqMDgh0nSVfoD8FmyHNgoF+ueItj6iG8zoK74P7y7O3mTdDb slQ8sPwn8RRzNr15FZNZX7jMNNd62iXJ3I3yD/xHLRoxh6xVQzIn0FIUKHPod1kjrr+M=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k3eBj-0000so-8b; Thu, 06 Aug 2020 11:35:59 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3eBj-0003MP-1n; Thu, 06 Aug 2020 11:35:59 +0000 Subject: Re: [RFC PATCH V1 08/12] xen/arm: Invalidate qemu mapcache on XENMEM_decrease_reservation To: Jan Beulich , Oleksandr Tyshchenko References: <1596478888-23030-1-git-send-email-olekstysh@gmail.com> <1596478888-23030-9-git-send-email-olekstysh@gmail.com> <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> From: Julien Grall Message-ID: Date: Thu, 6 Aug 2020 12:35:56 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <21b7d8ed-f305-8abe-0e4e-174d72d087c8@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Volodymyr Babchuk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Jan, On 05/08/2020 17:21, Jan Beulich wrote: > On 03.08.2020 20:21, Oleksandr Tyshchenko wrote: >> --- a/xen/common/memory.c >> +++ b/xen/common/memory.c >> @@ -1652,6 +1652,12 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) >> break; >> } >> >> + /* x86 already sets the flag in hvm_memory_op() */ >> +#if defined(CONFIG_ARM64) && defined(CONFIG_IOREQ_SERVER) >> + if ( op == XENMEM_decrease_reservation ) >> + curr_d->arch.hvm.qemu_mapcache_invalidate = true; >> +#endif > > Doesn't the comment already indicate a route towards an approach > not requiring to alter common code? Given that IOREQ is now moved under common/, I think it would make sense to have this set in common code as well for all the architecture. IOW, I would suggest to drop the #ifdef CONFIG_ARM64. In addition, we may want to introduce an helper to check if a domain is using ioreq. Cheers, -- Julien Grall