From: Jan Beulich <jbeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: artur@puzio.waw.pl, Wei Liu <wl@xen.org>,
jakub@bartmin.ski, Andrew Cooper <andrew.cooper3@citrix.com>,
marmarek@invisiblethingslab.com,
Grzegorz Uriasz <gorbak25@gmail.com>,
j.nowak26@student.uw.edu.pl, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/1] x86/acpi: Use FADT flags to determine the PMTMR width
Date: Tue, 16 Jun 2020 17:11:58 +0200 [thread overview]
Message-ID: <cfe13cc5-ce0a-a50f-fed6-8546407d2e81@suse.com> (raw)
In-Reply-To: <20200616145951.GP735@Air-de-Roger>
On 16.06.2020 16:59, Roger Pau Monné wrote:
> On Tue, Jun 16, 2020 at 03:25:42PM +0200, Jan Beulich wrote:
>> --- unstable.orig/xen/arch/x86/acpi/boot.c
>> +++ unstable/xen/arch/x86/acpi/boot.c
>> @@ -480,7 +480,9 @@ static int __init acpi_parse_fadt(struct
>> if (fadt->header.revision >= FADT2_REVISION_ID) {
>> /* FADT rev. 2 */
>> if (fadt->xpm_timer_block.space_id ==
>> - ACPI_ADR_SPACE_SYSTEM_IO) {
>> + ACPI_ADR_SPACE_SYSTEM_IO &&
>> + (fadt->xpm_timer_block.access_width == 0 ||
>> + fadt->xpm_timer_block.access_width == 3)) {
>
> We should really have defines for those values, or else they seem to
> imply actual access sizes. What about adding
> ACPI_ADDR_ACCESS_{LEGACY,BYTE,WORD,DWORD,QWORD}?
If there were such defines, I'd have used them. Adding them is
inappropriate though, as this would modify an imported header in a
Xen-specific way. We could leverage ACPI_ACCESS_BIT_WIDTH() here,
though.
> Also the check for the access size seems kind of unrelated to the
> patch itself? (not that I'm opposed to it)
It's related, but could also live in its own patch.
Jan
next prev parent reply other threads:[~2020-06-16 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 14:36 [PATCH 0/1] Fix broken suspend on some machines Grzegorz Uriasz
2020-06-14 14:36 ` [PATCH 1/1] x86/acpi: Use FADT flags to determine the PMTMR width Grzegorz Uriasz
2020-06-15 7:05 ` Roger Pau Monné
2020-06-16 8:07 ` Jan Beulich
2020-06-16 10:32 ` Roger Pau Monné
2020-06-16 12:31 ` Jan Beulich
2020-06-16 13:25 ` Jan Beulich
2020-06-16 14:59 ` Roger Pau Monné
2020-06-16 15:10 ` Grzegorz Uriasz
2020-06-16 15:13 ` Jan Beulich
2020-06-16 15:11 ` Jan Beulich [this message]
2020-06-16 15:25 ` Roger Pau Monné
2020-06-17 6:16 ` Grzegorz Uriasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfe13cc5-ce0a-a50f-fed6-8546407d2e81@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=artur@puzio.waw.pl \
--cc=gorbak25@gmail.com \
--cc=j.nowak26@student.uw.edu.pl \
--cc=jakub@bartmin.ski \
--cc=marmarek@invisiblethingslab.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).