From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 0/6] xenconsoled: rotating log file abstration Date: Mon, 6 Jun 2016 15:40:33 -0500 Message-ID: References: <1465228781-22754-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2368214334442352525==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA1K9-0006j5-Sf for xen-devel@lists.xenproject.org; Mon, 06 Jun 2016 20:40:38 +0000 Received: by mail-yw0-f193.google.com with SMTP id n16so20563852ywd.2 for ; Mon, 06 Jun 2016 13:40:33 -0700 (PDT) In-Reply-To: <1465228781-22754-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu , Xen-devel Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2368214334442352525== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tUwHH0dME0l8uoDxcNM3eevsG4j9DESTJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tUwHH0dME0l8uoDxcNM3eevsG4j9DESTJ Content-Type: multipart/mixed; boundary="tR2bwCaTLrOtQlg2x3s9fF4ihAqRMP87O" From: Doug Goldstein To: Wei Liu , Xen-devel Cc: Ian Jackson Message-ID: Subject: Re: [Xen-devel] [PATCH 0/6] xenconsoled: rotating log file abstration References: <1465228781-22754-1-git-send-email-wei.liu2@citrix.com> In-Reply-To: <1465228781-22754-1-git-send-email-wei.liu2@citrix.com> --tR2bwCaTLrOtQlg2x3s9fF4ihAqRMP87O Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 6/6/16 10:59 AM, Wei Liu wrote: > Wei Liu (6): > xenconsoled: introduce log file abstraction > xenconsoled: switch hypervisor log to use logfile abstraction > xenconsoled: switch guest log to use logfile abstraction > xenconsoled: delete two now unused functions > xenconsoled: options to control log rotation > xenconsoled: handle --log-backups 0 in logfile_rollover >=20 > tools/console/daemon/io.c | 139 +++++++++++------------ > tools/console/daemon/logfile.c | 243 +++++++++++++++++++++++++++++++++= ++++++++ > tools/console/daemon/logfile.h | 57 ++++++++++ > tools/console/daemon/main.c | 13 ++- > 4 files changed, 383 insertions(+), 69 deletions(-) > create mode 100644 tools/console/daemon/logfile.c > create mode 100644 tools/console/daemon/logfile.h >=20 Is there a mechanism for me to turn this off entirely? Due to some very real possibilities like logging overwhelming xenconsoled and causing qemu to block this is just not something that I will be able to roll out in any of my deployments. We would rather lose logs than block qemu. --=20 Doug Goldstein --tR2bwCaTLrOtQlg2x3s9fF4ihAqRMP87O-- --tUwHH0dME0l8uoDxcNM3eevsG4j9DESTJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJXVd/DXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU60YP/3ee00QByoj/Aca4sNi0ihUO oWMBka6kQ//FHolL+P5fAIuOT2LRTmCw63mpi7KYfINrz1Z4h/l7Jpi7CcrpXQKi o+rFMXqLeMsqokMix6qjnntWu20fGROy+UHrDVY/3juWNdsPgOFRDD9gc+3MlYNZ tzPhwB3udk8JF6/WFATZSwv1u1KqNYY+DljI6qpYEH7RTKy16fIqv0H5G4DCn4Ww /cIYTvPPd/MUCdlraSlUakbP0hUarWCJX1IbugYlwPh22eQZq5OXz0rejXCXapUf pQJ5tXHrSQfVhXYZIhm4lRAWaL8SecdtVb/QccvcrnFrshCJ8vuqXgICWv5FOi18 1ZfnHQbyDLg41FHjFaTOztEyJjZlCGIdR/HStVxeV5k3kSTndsWRenxKdqcfSl91 wcNQtC2gjcRhP5TqSHZZ2MeVG51uPVtMxXQYelQmOA9AAgnHsuWZsAvo32lR3X12 ZgnOg1rm0od3brtez3va11B7+r8LOZYB0PlP666+I6z3v/+qVENIvBANhKr1Bxnv socopmJGY5j4kT4R72EBjHg3eLQ6NH0HU29k73wKTrLbGXPJANFiqrxWBN1+uphR NVQs2l3xloicgzHXdhi7spccvCww6vmRwVWCn92gkwWgcsMiceUvUJjuMiZI8uam SA78jqOT8BCp3C35kqXX =7rbg -----END PGP SIGNATURE----- --tUwHH0dME0l8uoDxcNM3eevsG4j9DESTJ-- --===============2368214334442352525== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============2368214334442352525==--