From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org
Cc: jgross@suse.com, paul@xen.org
Subject: Re: [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Prevent NULL deference in flask_assign_{, dt}device()
Date: Fri, 4 Oct 2019 13:58:36 -0400 [thread overview]
Message-ID: <d148b549-ee2c-5279-0395-b2e7edf24b5c@tycho.nsa.gov> (raw)
In-Reply-To: <20191004164243.30822-1-julien.grall@arm.com>
On 10/4/19 12:42 PM, Julien Grall wrote:
> flask_assign_{, dt}device() may be used to check whether you can test if
> a device is assigned. In this case, the domain will be NULL.
>
> However, flask_iommu_resource_use_perm() will be called and may end up
> to deference a NULL pointer. This can be prevented by moving the call
> after we check the validity for the domain pointer.
>
> Coverity-ID: 1486741
> Fixes: 71e617a6b8 ('use is_iommu_enabled() where appropriate...')
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-04 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 16:42 [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Prevent NULL deference in flask_assign_{, dt}device() Julien Grall
2019-10-04 17:58 ` Daniel De Graaf [this message]
2019-10-05 12:05 ` Paul Durrant
2019-10-07 6:52 ` Jürgen Groß
2019-10-09 11:57 ` Artem Mygaiev
2019-10-10 14:48 ` Julien Grall
2019-10-10 15:07 ` Artem Mygaiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d148b549-ee2c-5279-0395-b2e7edf24b5c@tycho.nsa.gov \
--to=dgdegra@tycho.nsa.gov \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=paul@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).