From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0D5C433FE for ; Mon, 7 Dec 2020 11:41:15 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D999323356 for ; Mon, 7 Dec 2020 11:41:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D999323356 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.46342.82239 (Exim 4.92) (envelope-from ) id 1kmEt4-0000ex-DU; Mon, 07 Dec 2020 11:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 46342.82239; Mon, 07 Dec 2020 11:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmEt4-0000eq-AL; Mon, 07 Dec 2020 11:41:02 +0000 Received: by outflank-mailman (input) for mailman id 46342; Mon, 07 Dec 2020 11:41:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmEt2-0000eg-Eu for xen-devel@lists.xenproject.org; Mon, 07 Dec 2020 11:41:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 03f2969b-d11b-4ea5-a8da-12da4c22efa7; Mon, 07 Dec 2020 11:40:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9AD65AC90; Mon, 7 Dec 2020 11:40:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03f2969b-d11b-4ea5-a8da-12da4c22efa7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607341258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ktigrgzOccHxvbusY6yLdeGC0ejiIpTZQxtFb509trE=; b=pyWbUnb8Lz9Z0DiRgRroPSX6T0WKb/XJ3LiuaPgure2wECRbH5bePBC/z3fKLEy/WmVvJb 5DXYyUqRX/LqNom+oWlKGWQKN4260RBPO8T445kPEa+94l8VcztrAFK6XHCdzSebZ1QMgl 9A5+DNoSRYErcsgfebTsfoM8D9Zi86A= Subject: Re: [PATCH V3 04/23] xen/ioreq: Make x86's IOREQ feature common To: Oleksandr Tyshchenko Cc: Oleksandr Tyshchenko , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant , Tim Deegan , Julien Grall , xen-devel@lists.xenproject.org References: <1606732298-22107-1-git-send-email-olekstysh@gmail.com> <1606732298-22107-5-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: Date: Mon, 7 Dec 2020 12:41:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <1606732298-22107-5-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 30.11.2020 11:31, Oleksandr Tyshchenko wrote: > --- a/xen/include/asm-x86/hvm/ioreq.h > +++ b/xen/include/asm-x86/hvm/ioreq.h > @@ -19,8 +19,7 @@ > #ifndef __ASM_X86_HVM_IOREQ_H__ > #define __ASM_X86_HVM_IOREQ_H__ > > -#define HANDLE_BUFIOREQ(s) \ > - ((s)->bufioreq_handling != HVM_IOREQSRV_BUFIOREQ_OFF) > +#include Is there a strict need to do it this way round? Usually the common header would include the arch one ... > @@ -38,42 +37,6 @@ int arch_ioreq_server_get_type_addr(const struct domain *d, > uint64_t *addr); > void arch_ioreq_domain_init(struct domain *d); As already mentioned in an earlier reply: What about these? They shouldn't get declared once per arch. If anything, ones that want to be inline functions can / should remain in the per-arch header. Jan