From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Paul Durrant <paul@xen.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
xen-devel@lists.xenproject.org,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH v2 3/4] hw/xen/Kconfig: Introduce XEN_PV config
Date: Mon, 1 Feb 2021 11:59:53 +0100 [thread overview]
Message-ID: <d3ad42eb-42bd-2e63-4c99-8eed91216fc5@amsat.org> (raw)
In-Reply-To: <20210131141810.293186-4-f4bug@amsat.org>
On 1/31/21 3:18 PM, Philippe Mathieu-Daudé wrote:
> xenpv machine requires USB, IDE_PIIX and PCI:
>
> /usr/bin/ld:
> libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common':
> hw/xen/xen-legacy-backend.c:757: undefined reference to `xen_usb_ops'
> libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `unplug_disks':
> hw/i386/xen/xen_platform.c:153: undefined reference to `pci_piix3_xen_ide_unplug'
> libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `pci_unplug_nics':
> hw/i386/xen/xen_platform.c:137: undefined reference to `pci_for_each_device'
> libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `xen_platform_realize':
> hw/i386/xen/xen_platform.c:483: undefined reference to `pci_register_bar'
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/Kconfig | 1 +
> hw/xen/Kconfig | 7 +++++++
> 2 files changed, 8 insertions(+)
> create mode 100644 hw/xen/Kconfig
>
> diff --git a/hw/Kconfig b/hw/Kconfig
> index 5ad3c6b5a4b..f2a95591d94 100644
> --- a/hw/Kconfig
> +++ b/hw/Kconfig
> @@ -39,6 +39,7 @@ source usb/Kconfig
> source virtio/Kconfig
> source vfio/Kconfig
> source watchdog/Kconfig
> +source xen/Kconfig
>
> # arch Kconfig
> source arm/Kconfig
> diff --git a/hw/xen/Kconfig b/hw/xen/Kconfig
> new file mode 100644
> index 00000000000..0b8427d6bd1
> --- /dev/null
> +++ b/hw/xen/Kconfig
> @@ -0,0 +1,7 @@
> +config XEN_PV
> + bool
> + default y if XEN
> + depends on XEN
> + select PCI
> + select USB
> + select IDE_PIIX
Well this is not enough, --without-default-devices fails:
/usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in
function `cpu_physical_memory_set_dirty_range':
include/exec/ram_addr.h:333: undefined reference to
`xen_hvm_modified_memory'
/usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in
function `ram_block_add':
softmmu/physmem.c:1873: undefined reference to `xen_ram_alloc'
/usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in
function `cpu_physical_memory_set_dirty_range':
include/exec/ram_addr.h:333: undefined reference to
`xen_hvm_modified_memory'
/usr/bin/ld: include/exec/ram_addr.h:333: undefined reference to
`xen_hvm_modified_memory'
/usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_memory.c.o: in function
`cpu_physical_memory_set_dirty_range':
include/exec/ram_addr.h:333: undefined reference to
`xen_hvm_modified_memory'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
next prev parent reply other threads:[~2021-02-01 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210131141810.293186-1-f4bug@amsat.org>
[not found] ` <20210131141810.293186-2-f4bug@amsat.org>
[not found] ` <6ea50cf0-344d-cf9b-0a20-0444b3764f2d@citrix.com>
2021-01-31 18:54 ` [PATCH v2 1/4] meson: Do not build Xen x86_64-softmmu on Aarch64 Philippe Mathieu-Daudé
[not found] ` <20210131141810.293186-5-f4bug@amsat.org>
2021-02-01 8:34 ` [PATCH v2 4/4] hw/xen: Have Xen machines select 9pfs Paolo Bonzini
2021-02-01 9:18 ` Philippe Mathieu-Daudé
2021-02-01 10:23 ` Paolo Bonzini
2021-02-01 11:03 ` Philippe Mathieu-Daudé
[not found] ` <20210131141810.293186-4-f4bug@amsat.org>
2021-02-01 10:59 ` Philippe Mathieu-Daudé [this message]
2021-02-01 11:11 ` [PATCH v2 3/4] hw/xen/Kconfig: Introduce XEN_PV config Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3ad42eb-42bd-2e63-4c99-8eed91216fc5@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).