From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33F9C64E8A for ; Mon, 30 Nov 2020 10:16:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 389F420679 for ; Mon, 30 Nov 2020 10:16:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="DJNZ9lcM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 389F420679 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.40774.73693 (Exim 4.92) (envelope-from ) id 1kjgEB-0006Oc-VR; Mon, 30 Nov 2020 10:16:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 40774.73693; Mon, 30 Nov 2020 10:16:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kjgEB-0006OV-Qp; Mon, 30 Nov 2020 10:16:15 +0000 Received: by outflank-mailman (input) for mailman id 40774; Mon, 30 Nov 2020 10:16:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kjgEA-0006OK-8z for xen-devel@lists.xenproject.org; Mon, 30 Nov 2020 10:16:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1c41cb51-c734-4156-b1f1-ad3f04dd2374; Mon, 30 Nov 2020 10:16:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E14EBACB5; Mon, 30 Nov 2020 10:16:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c41cb51-c734-4156-b1f1-ad3f04dd2374 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606731372; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fFi+ssvb0SZ1fooUTaC0EQMDJk1EiU6HlH7OlP+oWQ0=; b=DJNZ9lcMRM5+oCGgrN4rhi+4nwj75VO7AQa/VL44QVRMBWDGN+2sLKcNHfWRiSswuRLoZR sDrna/BF327HgNCk3TPYTcOSq1OlUoX4ifzMJqVPT3K4K+LQEEHKvbejVhEkdlR7wQxAU4 y+7aCuiW1X7HEY/WcRsRguPGPYC2Apk= Subject: Re: [PATCH 04/16] x86/srat: vmap the pages for acpi_slit To: Hongyan Xia Cc: julien@xen.org, Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: From: Jan Beulich Message-ID: Date: Mon, 30 Nov 2020 11:16:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 30.04.2020 22:44, Hongyan Xia wrote: > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -196,7 +196,8 @@ void __init acpi_numa_slit_init(struct acpi_table_slit *slit) > return; > } > mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); > - acpi_slit = mfn_to_virt(mfn_x(mfn)); > + acpi_slit = vmap_boot_pages(mfn, PFN_UP(slit->header.length)); > + BUG_ON(!acpi_slit); > memcpy(acpi_slit, slit, slit->header.length); > } I'm not sure in how far this series is still to be considered active / pending; I still have it in my inbox as something to look at in any event. If it is, then I think the latest by this patch it becomes clear that we either want to make vmalloc() boot-allocator capable, or introduce e.g. vmalloc_boot(). Having this recurring pattern including the somewhat odd vmap_boot_pages() is imo not the best way forward. It would then also no longer be necessary to allocate contiguous pages, as none of the users up to here appear to have such a need. Jan