From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3109C433ED for ; Tue, 13 Apr 2021 15:15:00 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 274886117A for ; Tue, 13 Apr 2021 15:15:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 274886117A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ipxe.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.109935.209840 (Exim 4.92) (envelope-from ) id 1lWKke-0005qL-IO; Tue, 13 Apr 2021 15:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 109935.209840; Tue, 13 Apr 2021 15:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWKke-0005qE-Es; Tue, 13 Apr 2021 15:14:52 +0000 Received: by outflank-mailman (input) for mailman id 109935; Tue, 13 Apr 2021 15:14:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWKkc-0005q8-Ji for xen-devel@lists.xenproject.org; Tue, 13 Apr 2021 15:14:50 +0000 Received: from blyat.fensystems.co.uk (unknown [54.246.183.96]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f2953e1c-8cd5-4c95-8b18-f77f74c554ce; Tue, 13 Apr 2021 15:14:49 +0000 (UTC) Received: from dolphin.home (unknown [IPv6:2a00:23c6:5495:5e00:72b3:d5ff:feb1:e101]) by blyat.fensystems.co.uk (Postfix) with ESMTPSA id DEBBC4427E; Tue, 13 Apr 2021 15:14:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2953e1c-8cd5-4c95-8b18-f77f74c554ce Subject: Re: xen-netback hotplug-status regression bug To: paul@xen.org, Wei Liu , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, Paul Durrant References: <58ccc3b7-9ccb-b9bf-84e7-4a023ccb5c56@ipxe.org> <54659eec-e315-5dc5-1578-d91633a80077@xen.org> From: Michael Brown Message-ID: Date: Tue, 13 Apr 2021 16:14:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <54659eec-e315-5dc5-1578-d91633a80077@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 13/04/2021 11:55, Paul Durrant wrote: > Ok, so it sound like this was probably my misunderstanding of xenstore > semantics in the first place (although I'm sure I remember watch > registration failing for non-existent nodes at some point in the past... > that may have been with a non-upstream version of oxenstored though). > > Anyway... a reasonable fix would therefore be to read the node first and > only register the watch if it does exist. Thanks. Patch coming up shortly! Michael