From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32B60C3DA7A for ; Fri, 6 Jan 2023 13:41:13 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.472605.732880 (Exim 4.92) (envelope-from ) id 1pDmxq-0002XZ-93; Fri, 06 Jan 2023 13:40:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472605.732880; Fri, 06 Jan 2023 13:40:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmxq-0002XS-6S; Fri, 06 Jan 2023 13:40:54 +0000 Received: by outflank-mailman (input) for mailman id 472605; Fri, 06 Jan 2023 13:40:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmxo-0002XK-Ky for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:40:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmxo-00082r-7K; Fri, 06 Jan 2023 13:40:52 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.4.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDmxo-0001Dv-0C; Fri, 06 Jan 2023 13:40:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=pHwJANpkRcSFgmVES30QT1jRvgzCAyd+JZcZ0J+t3G4=; b=fDT4xYoOMSMvX2R8xytxQG0yJZ 0RcDYcDeS5Xe+Iy7oZYXr0p9Zr7Bd00eR1p22/OZ0mYVDdkgTntLbNjMTiUbEe24usMnQ4cMpD879 WtPgxwtvA/+XIY3tBYIMggLt2O4Cqym+z+dAbrCvFfH8aYdWK6yaTln9710nKqrdUsNw=; Message-ID: Date: Fri, 6 Jan 2023 13:40:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/01/2023 13:14, Oleksii Kurochko wrote: > The patch introduce sbi_putchar() SBI call which is necessary > to implement initial early_printk > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ > xen/arch/riscv/sbi.c | 44 ++++++++++++++++++++++++++++++++ IMHO, it would be better to implement sbi.c in assembly so you can use print in the console before you jump to C world. > 3 files changed, 79 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/sbi.h > create mode 100644 xen/arch/riscv/sbi.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 5a67a3f493..60db415654 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,5 +1,6 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += setup.o > +obj-y += sbi.o Please order the filename alphabetically. Cheers, -- Julien Grall