xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jürgen Groß" <jgross@suse.com>
To: Jason Andryuk <jandryuk@gmail.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xen: Kconfig: nest Xen guest options
Date: Thu, 15 Oct 2020 11:41:58 +0200	[thread overview]
Message-ID: <d8a8ed95-ed55-4ccf-1b54-8d97db908742@suse.com> (raw)
In-Reply-To: <20201014175342.152712-3-jandryuk@gmail.com>

On 14.10.20 19:53, Jason Andryuk wrote:
> Moving XEN_512GB allows it to nest under XEN_PV.  That also allows
> XEN_PVH to nest under XEN as a sibling to XEN_PV and XEN_PVHVM giving:
> 
> [*]   Xen guest support
> [*]     Xen PV guest support
> [*]       Limit Xen pv-domain memory to 512GB
> [*]       Xen PV Dom0 support

This has currently a wrong text/semantics:

It should be split to CONFIG_XEN_DOM0 and CONFIG_XEN_PV_DOM0.

Otherwise the backends won't be enabled per default for a PVH-only
config meant to be Dom0-capable.

You don't have to do that in your patches if you don't want to, but
I wanted to mention it with you touching this area of Kconfig.

> [*]     Xen PVHVM guest support
> [*]     Xen PVH guest support
> 
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


  reply	other threads:[~2020-10-15  9:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 17:53 [PATCH 0/2] Remove Xen PVH dependency on PCI Jason Andryuk
2020-10-14 17:53 ` [PATCH 1/2] xen: Remove Xen PVH/PVHVM " Jason Andryuk
2020-10-15  8:10   ` Jan Beulich
2020-10-15 14:59     ` Jason Andryuk
2020-10-15 15:02       ` Jan Beulich
2020-10-15 15:08         ` Roger Pau Monné
2020-10-14 17:53 ` [PATCH 2/2] xen: Kconfig: nest Xen guest options Jason Andryuk
2020-10-15  9:41   ` Jürgen Groß [this message]
2020-10-15 14:52     ` Jason Andryuk
2020-10-15 12:37   ` boris.ostrovsky
2020-10-15 13:10     ` Andrew Cooper
2020-10-15 13:17       ` boris.ostrovsky
2020-10-15 14:50         ` Jason Andryuk
2020-10-14 18:04 ` [SUSPECTED SPAM][PATCH 0/2] Remove Xen PVH dependency on PCI Andrew Cooper
2020-10-14 19:31   ` Jason Andryuk
2020-12-16  7:01 ` [PATCH " Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8a8ed95-ed55-4ccf-1b54-8d97db908742@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jandryuk@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).