From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org, Paul Durrant <paul@xen.org>,
Richard Henderson <richard.henderson@linaro.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
xen-devel@lists.xenproject.org,
Anthony Perard <anthony.perard@citrix.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] hw/i386/xen: Remove dead code
Date: Sat, 13 Feb 2021 23:37:43 +0100 [thread overview]
Message-ID: <d8c7c2c9-031c-3534-d828-c3b232edc674@vivier.eu> (raw)
In-Reply-To: <20210202155644.998812-1-philmd@redhat.com>
Le 02/02/2021 à 16:56, Philippe Mathieu-Daudé a écrit :
> 'drivers_blacklisted' is never accessed, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/i386/xen/xen_platform.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c
> index 7c4db35debb..01ae1fb1618 100644
> --- a/hw/i386/xen/xen_platform.c
> +++ b/hw/i386/xen/xen_platform.c
> @@ -60,7 +60,6 @@ struct PCIXenPlatformState {
> MemoryRegion bar;
> MemoryRegion mmio_bar;
> uint8_t flags; /* used only for version_id == 2 */
> - int drivers_blacklisted;
> uint16_t driver_product_version;
>
> /* Log from guest drivers */
> @@ -245,18 +244,10 @@ static void platform_fixed_ioport_writeb(void *opaque, uint32_t addr, uint32_t v
>
> static uint32_t platform_fixed_ioport_readw(void *opaque, uint32_t addr)
> {
> - PCIXenPlatformState *s = opaque;
> -
> switch (addr) {
> case 0:
> - if (s->drivers_blacklisted) {
> - /* The drivers will recognise this magic number and refuse
> - * to do anything. */
> - return 0xd249;
> - } else {
> - /* Magic value so that you can identify the interface. */
> - return 0x49d2;
> - }
> + /* Magic value so that you can identify the interface. */
> + return 0x49d2;
> default:
> return 0xffff;
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2021-02-13 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 15:56 [PATCH] hw/i386/xen: Remove dead code Philippe Mathieu-Daudé
2021-02-02 16:05 ` Paul Durrant
2021-02-02 16:39 ` Paolo Bonzini
2021-02-13 22:37 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8c7c2c9-031c-3534-d828-c3b232edc674@vivier.eu \
--to=laurent@vivier.eu \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).