Re: [Xen-devel] [SUSPECTED SPAM]Xen-unstable staging build broken by pvshim patches.

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 09/08/2019 00:28, Sander Eikelenboom wrote:
> On 09/08/2019 00:44, Andrew Cooper wrote:
>> On 08/08/2019 23:34, Sander Eikelenboom wrote:
>>> On 08/08/2019 23:14, Andrew Cooper wrote:
>>>> On 08/08/2019 22:16, Sander Eikelenboom wrote:
>>>>> On 08/08/2019 23:05, Andrew Cooper wrote:
>>>>>> On 08/08/2019 21:59, Sander Eikelenboom wrote:
>>>>>>> Hi Andrew,
>>>>>>>
>>>>>>> It seems the pvshim patches in xen-unstable staging break the build on my machine.
>>>>>>> I cloned a fresh tree to be sure, haven't checked which of the two commits causes it:
>>>>>>> 060f4eee0fb408b316548775ab921e16b7acd0e0 or 32b1d62887d01f85f0c1d2e0103f69f74e1f6fa3
>>>>>>>
>>>>>>> --
>>>>>>> Sander
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> [ -d //usr/local/lib/xen/boot ] || /usr/src/new/xen-unstable/tools/firmware/../../tools/cross-install -d -m0755 -p //usr/local/lib/xen/boot
>>>>>>> [ -d //usr/local/lib/debug/usr/local/lib/xen/boot ] || /usr/src/new/xen-unstable/tools/firmware/../../tools/cross-install -d -m0755 -p //usr/local/lib/debug/usr/local/lib/xen/boot
>>>>>>> [ ! -e hvmloader/hvmloader ] || /usr/src/new/xen-unstable/tools/firmware/../../tools/cross-install -m0644 -p hvmloader/hvmloader //usr/local/lib/xen/boot
>>>>>>> /usr/src/new/xen-unstable/tools/firmware/../../tools/cross-install -m0644 -p seabios-dir/out/bios.bin //usr/local/lib/xen/boot/seabios.bin
>>>>>>> /usr/src/new/xen-unstable/tools/firmware/../../tools/cross-install -m0644 -p xen-dir/xen-shim //usr/local/lib/xen/boot/xen-shim
>>>>>>> install: cannot stat 'xen-dir/xen-shim': No such file or directory
>>>>>>> make[4]: *** [Makefile:52: install] Error 1
>>>>>>> make[4]: Leaving directory '/usr/src/new/xen-unstable/tools/firmware'
>>>>>>> make[3]: *** [/usr/src/new/xen-unstable/tools/../tools/Rules.mk:237: subdir-install-firmware] Error 2
>>>>>>> make[3]: Leaving directory '/usr/src/new/xen-unstable/tools'
>>>>>>> make[2]: *** [/usr/src/new/xen-unstable/tools/../tools/Rules.mk:232: subdirs-install] Error 2
>>>>>>> make[2]: Leaving directory '/usr/src/new/xen-unstable/tools'
>>>>>>> make[1]: *** [Makefile:73: install] Error 2
>>>>>>> make[1]: Leaving directory '/usr/src/new/xen-unstable/tools'
>>>>>>> make: *** [Makefile:131: install-tools] Error 2
>>>>>> That's weird.
>>>>>>
>>>>>> Do you have the full log?  The real failure was somewhere earlier where
>>>>>> xen-shim didn't get started.
>>>>>>
>>>>>> ~Andrew
>>>>>>
>>>>> Hmm if forgot and thus forgot to mention my build script disables some stuff:
>>>>> ./configure --disable-qemu-traditional --disable-stubdom --disable-docs --disable-rombios
>>>>>
>>>>> Could be that one of those doesn't work anymore.
>>>> The only interesting one would be --disable-rombios, which does make
>>>> changes in this area of the build, but everything I changed was inside
>>>> the xen-dir/ directory so shouldn't interact.>
>>>> ~Andrew
>>>>
>>> It indeed seems to be some interaction with --disable-rombios, with just
>>> a plain ./configure it builds fine.
>>> Logs when building with --disable-rombios are attached.
>> Right.  So the build itself works, but the subsequent `make install` fails.
>>
>> And to confirm, a build of 8d54a6adf (the parent of my first shim
>> commit) works entirely fine?
>>
>> ~Andrew
>>
> Just rechecked, and yes that builds and installs fine (with --disable-rombios).

Which base distro are you using?  I'm unable to reproduce any build
failures locally.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel