From: Julien Grall <julien@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH] ARM/boot: Don't poison 'current' during early boot
Date: Wed, 15 Jan 2020 18:45:59 +0000 [thread overview]
Message-ID: <db84e62b-694d-88ed-4b23-8b5df1cb0f2e@xen.org> (raw)
In-Reply-To: <20200115184358.21131-1-andrew.cooper3@citrix.com>
Hi,
On 15/01/2020 18:43, Andrew Cooper wrote:
> This logic was inherited from x86 (which was updated several times since).
> Unlike x86 (at the time) however, while NULL isn't mapped in ARM, 0xfffff000
> is, making this actively dangerous.
>
> Drop the logic entirely, and leave 'current' as NULL during early boot.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thank you for the cleanup!
Acked-by: Julien Grall <julien@xen.org>
Cheers,
> ---
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> ---
> xen/arch/arm/setup.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 3c899cd4a0..9dd3738d44 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -798,9 +798,6 @@ void __init start_xen(unsigned long boot_phys_offset,
> percpu_init_areas();
> set_processor_id(0); /* needed early, for smp_processor_id() */
>
> - set_current((struct vcpu *)0xfffff000); /* debug sanity */
> - idle_vcpu[0] = current;
> -
> setup_virtual_regions(NULL, NULL);
> /* Initialize traps early allow us to get backtrace when an error occurred */
> init_traps();
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2020-01-15 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 18:43 [Xen-devel] [PATCH] ARM/boot: Don't poison 'current' during early boot Andrew Cooper
2020-01-15 18:45 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db84e62b-694d-88ed-4b23-8b5df1cb0f2e@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).