From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Oleksandr Tyshchenko' <olekstysh@gmail.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "jgross@suse.com" <jgross@suse.com>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
"julien.grall@arm.com" <julien.grall@arm.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"volodymyr_babchuk@epam.com" <volodymyr_babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
Date: Mon, 30 Sep 2019 10:35:41 +0000 [thread overview]
Message-ID: <dbe10a2156ee45e0b7d317c593b75039@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <1569839671-772-1-git-send-email-olekstysh@gmail.com>
> -----Original Message-----
> From: Oleksandr Tyshchenko <olekstysh@gmail.com>
> Sent: 30 September 2019 11:35
> To: xen-devel@lists.xenproject.org
> Cc: julien.grall@arm.com; sstabellini@kernel.org; volodymyr_babchuk@epam.com; jgross@suse.com; Paul
> Durrant <Paul.Durrant@citrix.com>; Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Subject: [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
>
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> The Arm realization should have been removed in the following commit
> as redundant:
> f89f555 remove late (on-demand) construction of IOMMU page tables
>
> So, remove unused function completely.
Good catch.
Reviewed-by: Paul Durrant <paul@xen.org>
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> xen/drivers/passthrough/arm/iommu.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c
> index 76e1152..db3b07a 100644
> --- a/xen/drivers/passthrough/arm/iommu.c
> +++ b/xen/drivers/passthrough/arm/iommu.c
> @@ -132,12 +132,6 @@ void arch_iommu_domain_destroy(struct domain *d)
> {
> }
>
> -int arch_iommu_populate_page_table(struct domain *d)
> -{
> - /* The IOMMU shares the p2m with the CPU */
> - return -ENOSYS;
> -}
> -
> void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
> {
> }
> --
> 2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-30 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 10:34 [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely Oleksandr Tyshchenko
2019-09-30 10:35 ` Paul Durrant [this message]
2019-09-30 10:42 ` Julien Grall
2019-09-30 10:44 ` Jürgen Groß
2019-09-30 11:05 ` Oleksandr
2019-10-08 17:21 ` Oleksandr
2019-10-09 15:40 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbe10a2156ee45e0b7d317c593b75039@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=olekstysh@gmail.com \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).