xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Sergej Proskurin <proskurin@sec.in.tum.de>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.chen@linaro.org, steve.capper@arm.com
Subject: Re: [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create
Date: Fri, 22 Jul 2016 12:16:42 +0200	[thread overview]
Message-ID: <dd62160d-cabe-2a52-b27e-e99fc3a1d2db@sec.in.tum.de> (raw)
In-Reply-To: <53d8f601-7027-50aa-4a65-0136e65beb64@arm.com>

Hi Julien,

On 07/22/2016 11:18 AM, Julien Grall wrote:
> 
> 
> On 22/07/16 09:32, Sergej Proskurin wrote:
>> Hi Julien,
> 
> Hello Sergej,
> 
>>> -int p2m_alloc_table(struct domain *d)
>>> +static int p2m_alloc_table(struct domain *d)
>>
>> While moving parts of the altp2m code out of ./xen/arch/arm/p2m.c, the
>> function p2m_alloc_table needs to be called from ./xen/arch/arm/altp2m.c
>> to allocate the individual altp2m views. Hence it should not be static.
> 
> No, this function should not be called outside p2m.c as it will not
> fully initialize the p2m. You need to need to provide a function to
> initialize a p2m (such as p2m_init).
> 

The last time we have discussed reusing existing code, among others, for
individual struct p2m_domain initialization routines. Also, we have
agreed to move altp2m-related parts out of p2m.c into altp2m.c, which
makes it hard not to access parts required for initialization/teardown
(that are equal for both p2m and altp2m).

I agree that functions that, e.g., do not entirely initialize a specific
data structure should not be accessed from elsewhere. But then, we
should not have moved altp2m-related information out of p2m.c as they
simply need the same functionality when it comes to initialization/teardown.

Best regards,
~Sergej

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-07-22 10:16 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 16:10 [PATCH 00/22] xen/arm: P2M clean-up and fixes Julien Grall
2016-07-20 16:10 ` [PATCH 01/22] xen/arm: system: Use the correct parameter name in local_irq_restore Julien Grall
2016-07-22  1:19   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 02/22] xen/arm: p2m: Pass the vCPU in parameter to get_page_from_gva Julien Grall
2016-07-22  1:22   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 03/22] xen/arm: p2m: Restrict usage of get_page_from_gva to the current vCPU Julien Grall
2016-07-22  1:25   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 04/22] xen/arm: p2m: Fix multi-lines coding style comments Julien Grall
2016-07-22  1:26   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 05/22] xen/arm: p2m: Clean-up mfn_to_p2m_entry Julien Grall
2016-07-26 22:24   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 06/22] xen/arm: p2m: Use the typesafe MFN in mfn_to_p2m_entry Julien Grall
2016-07-26 22:28   ` Stefano Stabellini
2016-07-27  9:54     ` Julien Grall
2016-07-27 18:25       ` Stefano Stabellini
2016-07-27 20:14         ` Julien Grall
2016-07-20 16:10 ` [PATCH 07/22] xen/arm: p2m: Use p2m_is_foreign in get_page_from_gfn to avoid open coding Julien Grall
2016-07-26 22:33   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 08/22] xen/arm: p2m: Simplify p2m type check by using bitmask Julien Grall
2016-07-26 22:36   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 09/22] xen/arm: p2m: Use a whitelist rather than blacklist in get_page_from_gfn Julien Grall
2016-07-26 22:44   ` Stefano Stabellini
2016-07-27  9:59     ` Julien Grall
2016-07-27 17:56       ` Stefano Stabellini
2016-07-27 17:57         ` Julien Grall
2016-07-20 16:10 ` [PATCH 10/22] xen/arm: p2m: Differentiate cacheable vs non-cacheable MMIO Julien Grall
2016-07-26 22:47   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 11/22] xen/arm: p2m: Find the memory attributes based on the p2m type Julien Grall
2016-07-27  0:41   ` Stefano Stabellini
2016-07-27 17:15   ` Julien Grall
2016-07-27 17:55     ` Stefano Stabellini
2016-07-27 20:15       ` Julien Grall
2016-07-20 16:10 ` [PATCH 12/22] xen/arm: p2m: Remove unnecessary locking Julien Grall
2016-07-27  0:47   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 13/22] xen/arm: p2m: Introduce p2m_{read, write}_{, un}lock helpers Julien Grall
2016-07-27  0:50   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 14/22] xen/arm: p2m: Switch the p2m lock from spinlock to rwlock Julien Grall
2016-07-27  0:51   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create Julien Grall
2016-07-22  8:32   ` Sergej Proskurin
2016-07-22  9:18     ` Julien Grall
2016-07-22 10:16       ` Sergej Proskurin [this message]
2016-07-22 10:26         ` Julien Grall
2016-07-22 10:39           ` Sergej Proskurin
2016-07-22 10:38             ` Julien Grall
2016-07-22 11:05               ` Sergej Proskurin
2016-07-22 13:00                 ` Julien Grall
2016-07-23 17:59                   ` Sergej Proskurin
2016-07-27  0:54   ` Stefano Stabellini
2016-07-20 16:10 ` [PATCH 16/22] xen/arm: p2m: Move the vttbr field from arch_domain to p2m_domain Julien Grall
2016-07-22  7:46   ` Sergej Proskurin
2016-07-22  9:23     ` Julien Grall
2016-07-27  0:57   ` Stefano Stabellini
2016-07-27 10:00     ` Julien Grall
2016-07-27 17:19   ` Julien Grall
2016-07-20 16:10 ` [PATCH 17/22] xen/arm: p2m: Don't need to restore the state for an idle vCPU Julien Grall
2016-07-22  7:37   ` Sergej Proskurin
2016-07-27  1:05   ` Stefano Stabellini
2016-07-20 16:11 ` [PATCH 18/22] xen/arm: p2m: Rework the context switch to another VTTBR in flush_tlb_domain Julien Grall
2016-07-22  7:51   ` Sergej Proskurin
2016-07-27  1:12   ` Stefano Stabellini
2016-07-27 10:22     ` Julien Grall
2016-07-20 16:11 ` [PATCH 19/22] xen/arm: p2m: Inline p2m_load_VTTBR into p2m_restore_state Julien Grall
2016-07-22  8:07   ` Sergej Proskurin
2016-07-22  9:29     ` Julien Grall
2016-07-27  1:13   ` Stefano Stabellini
2016-07-20 16:11 ` [PATCH 20/22] xen/arm: Don't export flush_tlb_domain Julien Grall
2016-07-22  8:54   ` Sergej Proskurin
2016-07-22  9:30     ` Julien Grall
2016-07-22 10:25       ` Sergej Proskurin
2016-07-22 10:34         ` Julien Grall
2016-07-22 10:46           ` Sergej Proskurin
2016-07-22 10:57             ` Julien Grall
2016-07-22 11:22               ` Sergej Proskurin
2016-07-27  1:14   ` Stefano Stabellini
2016-07-20 16:11 ` [PATCH 21/22] xen/arm: p2m: Replace flush_tlb_domain by p2m_flush_tlb Julien Grall
2016-07-27  1:15   ` Stefano Stabellini
2016-07-20 16:11 ` [PATCH 22/22] xen/arm: p2m: Pass the p2m in parameter rather the domain when it is possible Julien Grall
2016-07-27  1:15   ` Stefano Stabellini
2016-07-22  1:31 ` [PATCH 00/22] xen/arm: P2M clean-up and fixes Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd62160d-cabe-2a52-b27e-e99fc3a1d2db@sec.in.tum.de \
    --to=proskurin@sec.in.tum.de \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=steve.capper@arm.com \
    --cc=wei.chen@linaro.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).