From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A582DC43463 for ; Mon, 21 Sep 2020 10:18:11 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25195207BC for ; Mon, 21 Sep 2020 10:18:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="iHdzEgGd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25195207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKItV-0000RQ-2I; Mon, 21 Sep 2020 10:18:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKItU-0000RK-AJ for xen-devel@lists.xenproject.org; Mon, 21 Sep 2020 10:18:00 +0000 X-Inumbo-ID: 910cb283-7f8f-4df6-b896-5b96674f4c58 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 910cb283-7f8f-4df6-b896-5b96674f4c58; Mon, 21 Sep 2020 10:17:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1600683478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=imezgL3etswMA0OdZciq//WXOmFSIHRj70An1wEyYTo=; b=iHdzEgGdQrxaMnZ8O3vrE1MJh52Th1lBihRfOv1joSgvWMNTcA4A72YvTiFGxX7H5BmZ23 HbvLf/jWH0PbY08inCGDWSt+DTNoJzgnLebHvdOY3O118QVHA3TLXgcmjcHaAs8HP7X3vP WIORbOlNS+b9YjsN1+ZWgq43vYCX1pg= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8769CAD71; Mon, 21 Sep 2020 10:18:34 +0000 (UTC) Subject: Ping: [PATCH 1/9] build: use if_changed more consistently (and correctly) for prelink*.o From: Jan Beulich To: Julien Grall , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <75d94bf1-b419-8a82-2d15-fb02e56109d8@suse.com> Message-ID: Date: Mon, 21 Sep 2020 12:17:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <75d94bf1-b419-8a82-2d15-fb02e56109d8@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 14.09.2020 12:15, Jan Beulich wrote: > Switch to $(call if_changed,ld) where possible; presumably not doing so > in e321576f4047 ("xen/build: start using if_changed") right away was an > oversight, as it did for Arm in (just) one case. It failed to add > prelink.o to $(targets), though, causing - judging from the observed > behavior on x86 - undue rebuilds of the final binary (because of > prelink.o getting rebuild for $(cmd_prelink.o) being empty, in turn > because of .prelink.o.cmd not getting read) during "make install-xen". > > Signed-off-by: Jan Beulich > --- > xen/arch/arm/Makefile | 4 +++- > xen/arch/x86/Makefile | 18 ++++++++++-------- > 2 files changed, 13 insertions(+), 9 deletions(-) May I ask for an Arm-side ack (or otherwise) here, please? Jan > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 51173d97127e..296c5e68bbc3 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -95,12 +95,14 @@ prelink_lto.o: $(ALL_OBJS) > > # Link it with all the binary objects > prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o > - $(LD) $(XEN_LDFLAGS) -r -o $@ $^ > + $(call if_changed,ld) > else > prelink.o: $(ALL_OBJS) FORCE > $(call if_changed,ld) > endif > > +targets += prelink.o > + > $(TARGET)-syms: prelink.o xen.lds > $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o \ > $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0 > diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile > index 74152f2a0dad..9b368632fb43 100644 > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -136,19 +136,21 @@ prelink_lto.o: $(ALL_OBJS) > $(LD_LTO) -r -o $@ $^ > > # Link it with all the binary objects > -prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o $(EFI_OBJS-y) > - $(LD) $(XEN_LDFLAGS) -r -o $@ $^ > +prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o $(EFI_OBJS-y) FORCE > + $(call if_changed,ld) > > -prelink-efi.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o > - $(LD) $(XEN_LDFLAGS) -r -o $@ $^ > +prelink-efi.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE > + $(call if_changed,ld) > else > -prelink.o: $(ALL_OBJS) $(EFI_OBJS-y) > - $(LD) $(XEN_LDFLAGS) -r -o $@ $^ > +prelink.o: $(ALL_OBJS) $(EFI_OBJS-y) FORCE > + $(call if_changed,ld) > > -prelink-efi.o: $(ALL_OBJS) > - $(LD) $(XEN_LDFLAGS) -r -o $@ $^ > +prelink-efi.o: $(ALL_OBJS) FORCE > + $(call if_changed,ld) > endif > > +targets += prelink.o prelink-efi.o > + > $(TARGET)-syms: prelink.o xen.lds > $(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \ > $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0 >