From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9D6C388F9 for ; Thu, 19 Nov 2020 10:24:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B313B2220B for ; Thu, 19 Nov 2020 10:24:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="urm+9VgS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B313B2220B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.30573.60685 (Exim 4.92) (envelope-from ) id 1kfh6b-0008Mw-Kw; Thu, 19 Nov 2020 10:23:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 30573.60685; Thu, 19 Nov 2020 10:23:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfh6b-0008Mp-Hd; Thu, 19 Nov 2020 10:23:57 +0000 Received: by outflank-mailman (input) for mailman id 30573; Thu, 19 Nov 2020 10:23:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfh6a-0008M6-Bu for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 10:23:56 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dde4293f-2209-413b-839a-79592bf37ed9; Thu, 19 Nov 2020 10:23:55 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EF87FAC24; Thu, 19 Nov 2020 10:23:54 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfh6a-0008M6-Bu for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 10:23:56 +0000 X-Inumbo-ID: dde4293f-2209-413b-839a-79592bf37ed9 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dde4293f-2209-413b-839a-79592bf37ed9; Thu, 19 Nov 2020 10:23:55 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605781435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XxzLM2t2efGhpZWBFlj6CCBvJpZP0Obk0XqAqTGxTek=; b=urm+9VgSdcp8uuGoltb2fQcU+Qwm7QxlyIu7U0jxwioABxLmsDyRCTK8hynWaRgPf2Vrwi m+FFZM+iaOG/fEjpQnUD7DSaHdK/ZuAvKeW4M7AS29RfZLQdDmKr7y/NTbNiMOWLvXF5tc jW8x8JTU6seoGtD8WvvjcgIlwhMol1k= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EF87FAC24; Thu, 19 Nov 2020 10:23:54 +0000 (UTC) Subject: Re: [PATCH v2 6/8] lib: move rbtree code To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: From: Jan Beulich Message-ID: Date: Thu, 19 Nov 2020 11:23:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 18.11.2020 18:46, Julien Grall wrote: > On 23/10/2020 11:18, Jan Beulich wrote: >> Build this code into an archive, which results in not linking it into >> x86 final binaries. This saves about 1.5k of dead code. >> >> While moving the source file, take the opportunity and drop the >> pointless EXPORT_SYMBOL(). > > Given this code is borrowed from Linux, I don't think we want to remove > them. This is to make easier to re-sync. That's one view on it. My view is that we should get rid of EXPORT_SYMBOL altogether (and it is a good opportunity to do so here). Not the least because otherwise for future cloning of Linux code we may then need to introduce further variants of this construct for no real purpose. >> --- a/xen/common/rbtree.c >> +++ b/xen/lib/rbtree.c >> @@ -25,7 +25,7 @@ >> #include >> >> /* >> - * red-black trees properties: http://en.wikipedia.org/wiki/Rbtree >> + * red-black trees properties: http://en.wikipedia.org/wiki/Rbtree > > This looks like a spurious change. Not really, no - while not visible here anymore, it's correcting an instance of trailing whitespace. Following your request on an earlier patch, I've also added half a sentence to the description here to mention this entirely benign change. Jan