From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3A9C43331 for ; Fri, 27 Mar 2020 07:51:10 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77EC520705 for ; Fri, 27 Mar 2020 07:51:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77EC520705 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHjky-0007Z9-AA; Fri, 27 Mar 2020 07:50:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHjkw-0007Z4-Ue for xen-devel@lists.xenproject.org; Fri, 27 Mar 2020 07:50:18 +0000 X-Inumbo-ID: 993127c6-6fff-11ea-a6c1-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 993127c6-6fff-11ea-a6c1-bc764e2007e4; Fri, 27 Mar 2020 07:50:17 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C2C95ACCE; Fri, 27 Mar 2020 07:50:13 +0000 (UTC) To: Andrew Cooper References: <1585230270-24178-1-git-send-email-puwen@hygon.cn> <92973061-0063-11de-5d5b-eb663de90cce@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 27 Mar 2020 08:50:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <92973061-0063-11de-5d5b-eb663de90cce@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Xen-devel] [PATCH v3] SVM: Add union intstat_t for offset 68h in vmcb struct X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Pu Wen , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 26.03.2020 14:56, Andrew Cooper wrote: > On 26/03/2020 13:44, Pu Wen wrote: >> According to chapter "Appendix B Layout of VMCB" in the new version >> (v3.32) AMD64 APM[1], bit 1 of the VMCB offset 68h is defined as >> GUEST_INTERRUPT_MASK. >> >> In current xen codes, it use whole u64 interrupt_shadow to setup >> interrupt shadow, which will misuse other bit in VMCB offset 68h >> as part of interrupt_shadow, causing svm_get_interrupt_shadow() to >> mistake the guest having interrupts enabled as being in an interrupt >> shadow. This has been observed to cause SeaBIOS to hang on boot. >> >> Add union intstat_t for VMCB offset 68h and fix codes to only use >> bit 0 as intr_shadow according to the new APM description. >> >> Reference: >> [1] https://www.amd.com/system/files/TechDocs/24593.pdf >> >> Signed-off-by: Pu Wen > > Reviewed-by: Andrew Cooper > > Although thinking about it, renaming irq_stat to irq_state would > probably be a good move.  I can fix this on commit - no need to send a v4. Assuming you meant intstat -> intstate and int_stat -> int_state, but in any event I don't think you've actually made the change while committing. Jan