From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2342AC433B4 for ; Thu, 29 Apr 2021 15:51:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB117611BE for ; Thu, 29 Apr 2021 15:51:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB117611BE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.120156.227210 (Exim 4.92) (envelope-from ) id 1lc8wb-0000aP-T0; Thu, 29 Apr 2021 15:51:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 120156.227210; Thu, 29 Apr 2021 15:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lc8wb-0000aI-PK; Thu, 29 Apr 2021 15:51:13 +0000 Received: by outflank-mailman (input) for mailman id 120156; Thu, 29 Apr 2021 15:51:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lc8wa-0000aB-Q5 for xen-devel@lists.xenproject.org; Thu, 29 Apr 2021 15:51:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6df97246-ae9e-4d53-a6eb-f047fd397faf; Thu, 29 Apr 2021 15:51:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE8AAAEA6; Thu, 29 Apr 2021 15:51:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6df97246-ae9e-4d53-a6eb-f047fd397faf X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619711470; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bkwe+HJmqmilqg8AsmCJ4pWgrTNaXBW/4xK6N4eMWhI=; b=X38kS2rSb94Q36f5n65BgkhmWtv8UxliONrobN+oO3BJmyb+BaQ0bOd9SkMs3uZGzSmWnc cIQNZu9nZbDmCVnqBig4YVl4Pa+Ohyr51xQPl+2jNyQ1+vWjiLY+8t8oXW0cCGWuS1Vc5T 5VSd7/BvwIJZNQ9YtPffLW09rjeMqA8= Subject: Re: [PATCH v4 04/12] x86/vioapic: switch to use the EOI callback mechanism To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20210420140723.65321-1-roger.pau@citrix.com> <20210420140723.65321-5-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 29 Apr 2021 17:51:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210420140723.65321-5-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 20.04.2021 16:07, Roger Pau Monne wrote: > Switch the emulated IO-APIC code to use the local APIC EOI callback > mechanism. This allows to remove the last hardcoded callback from > vlapic_handle_EOI. Removing the hardcoded vIO-APIC callback also > allows to getting rid of setting the EOI exit bitmap based on the > triggering mode, as now all users that require an EOI action use the > newly introduced callback mechanism. > > Move and rename the vioapic_update_EOI now that it can be made static. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich