From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 13/23] xen/arm: implement construct_domU Date: Mon, 15 Oct 2018 16:15:36 +0100 Message-ID: References: <1538765251-25256-13-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1538765251-25256-13-git-send-email-sstabellini@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Stefano Stabellini Cc: Stefano Stabellini , nd@arm.com, andrii_anisov@epam.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SGksCgpPbiAwNS8xMC8yMDE4IDE5OjQ3LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6Cj4gU2lt aWxhciB0byBjb25zdHJ1Y3RfZG9tMCwgY29uc3RydWN0X2RvbVUgY3JlYXRlcyBhIGJhcmVib25l IERvbVUgZ3Vlc3QuCj4gCj4gVGhlIGRldmljZSB0cmVlIG5vZGUgcGFzc2VkIGFzIGFyZ3VtZW50 IGlzIGNvbXBhdGlibGUgInhlbixkb21haW4iLCBzZWUKPiBkb2NzL21pc2MvYXJtL2RldmljZS10 cmVlL2Jvb3RpbmcudHh0Lgo+IAo+IEFkZCBjb25zdCB0byBrZXJuZWxfcHJvYmUgZHRfZGV2aWNl X25vZGUgcGFyYW1ldGVyLgoKVGhpcyBsaWtlbHkgYmVsb25ncyB0byBwYXRjaCAjNyB3aGVyZSB0 aGUgcGFyYW1ldGVyIHdhcyBhZGRlZC4KCj4gCj4gU2lnbmVkLW9mZi1ieTogU3RlZmFubyBTdGFi ZWxsaW5pIDxzdGVmYW5vc0B4aWxpbnguY29tPgo+IAo+IC0tLQo+IENoYW5nZXMgaW4gdjQ6Cj4g LSBjb25zdGlmeSBrZXJuZWxfcHJvYmUKPiAtIGNoYW5nZSB0aXRsZQo+IC0gYmV0dGVyIGVycm9y IG1lc3NhZ2VzIGFuZCBwcmludGVkIGluZm8KPiAtIDY0Yml0IG1lbW9yeQo+IAo+IENoYW5nZXMg aW4gdjM6Cj4gLSBtb3ZlIHNldHRpbmcgdHlwZSBiZWZvcmUgYWxsb2NhdGVfbWVtb3J5Cj4gLSBh ZGQgaWZkZWYgYXJvdW5kIGl0IGFuZCBhIGNvbW1lbnQKPiAKPiBDaGFuZ2VzIGluIHYyOgo+IC0g cmVuYW1lIG1lbSB0byBtZW1vcnkKPiAtIG1ha2UgY3B1cyBhbmQgbWVtb3J5IG1hbmRhdG9yeQo+ IC0gcmVtb3ZlIHdyb250IGNvbW1lbnQgZnJvbSBjb21taXQgbWVzc2FnZQo+IC0gY3B1cyBhbmQg bWVtb3J5IGFyZSByZWFkIGFzIGludGVnZXJzCj4gLSByZWFkIHRoZSB2cGwwMTEgb3B0aW9uCj4g LS0tCj4gICB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgfCAzNyArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tCj4gICB4ZW4vYXJjaC9hcm0va2VybmVsLmMgICAgICAgfCAg MyArKy0KPiAgIHhlbi9hcmNoL2FybS9rZXJuZWwuaCAgICAgICB8ICAyICstCj4gICAzIGZpbGVz IGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVp bGQuYwo+IGluZGV4IDU0N2I2MjQuLmVmYjUzMGEgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJt L2RvbWFpbl9idWlsZC5jCj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jCj4gQEAg LTM2OSw3ICszNjksNiBAQCBzdGF0aWMgdm9pZCBfX2luaXQgYWxsb2NhdGVfbWVtb3J5XzExKHN0 cnVjdCBkb21haW4gKmQsCj4gICAgICAgfQo+ICAgfQo+ICAgCj4gLSNpZiAwCgpQbGVhc2UgYWRk IGEgd29yZCBhYm91dCB0aGlzIGNoYW5nZSBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuCgo+ICAgc3Rh dGljIGJvb2wgX19pbml0IGFsbG9jYXRlX2JhbmtfbWVtb3J5KHN0cnVjdCBkb21haW4gKmQsCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGtlcm5lbF9p bmZvICpraW5mbywKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBn Zm5fdCBzZ2ZuLAo+IEBAIC00NTAsNyArNDQ5LDYgQEAgZmFpbDoKPiAgICAgICAgICAgICAgICh1 bnNpZ25lZCBsb25nKWtpbmZvLT51bmFzc2lnbmVkX21lbSA+PiAxMCk7Cj4gICAgICAgQlVHKCk7 Cj4gICB9Cj4gLSNlbmRpZgo+ICAgCj4gICBzdGF0aWMgaW50IF9faW5pdCB3cml0ZV9wcm9wZXJ0 aWVzKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBrZXJuZWxfaW5mbyAqa2luZm8sCj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9k ZSAqbm9kZSkKPiBAQCAtMjI5NCw3ICsyMjkyLDQwIEBAIHN0YXRpYyBpbnQgX19pbml0IF9fY29u c3RydWN0X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZv Cj4gICBzdGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tVShzdHJ1Y3QgZG9tYWluICpkLAo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGR0X2Rldmlj ZV9ub2RlICpub2RlKQo+ICAgewo+IC0gICAgcmV0dXJuIC1FTk9TWVM7Cj4gKyAgICBzdHJ1Y3Qg a2VybmVsX2luZm8ga2luZm8gPSB7fTsKPiArICAgIGludCByYzsKPiArICAgIHU2NCBtZW07Cj4g Kwo+ICsgICAgcmMgPSBkdF9wcm9wZXJ0eV9yZWFkX3U2NChub2RlLCAibWVtb3J5IiwgJm1lbSk7 Cj4gKyAgICBpZiAoICFyYyApCj4gKyAgICB7Cj4gKyAgICAgICAgcHJpbnRrKCJFcnJvciBidWls ZGluZyBEb21VOiBjYW5ub3QgcmVhZCBcIm1lbW9yeVwiIHByb3BlcnR5XG4iKTsKPiArICAgICAg ICByZXR1cm4gLUVJTlZBTDsKPiArICAgIH0KPiArICAgIGtpbmZvLnVuYXNzaWduZWRfbWVtID0g KHBhZGRyX3QpbWVtIDw8IDEwOwoKSSBub3RpY2VkIEkgZm9yZ290IHRvIGFuc3dlciB0bzoKIktC KCkgb25seSB3b3JrcyBmb3IgbnVtYmVycywgaXQgaXMgZGVmaW5lZCBhczogKF9BQyhfa2IsIFVM TCkgPDwgMTApIgoKdW5zaWduZWQgbG9uZyBsb25nIGlzIGFsd2F5cyBnb2luZyB0byBiZSBiaWdn ZXIgdGhhbiBwYWRkcl90LiBBbHNvLCB3ZSAKYWxyZWFkeSB1c2UgTUIoLi4uKSBpbiBzaW1pbGFy IHNpdHVhdGlvbi4gU28gSSBhbSBub3Qgc3VyZSB0byB1bmRlcnN0YW5kIAp5b3VyIGNvbmNlcm4g aGVyZS4KCj4gKwo+ICsgICAgcHJpbnRrKCIqKiogTE9BRElORyBET01VIGNwdXM9JXUgbWVtb3J5 PSVsdUtCICoqKlxuIiwgZC0+bWF4X3ZjcHVzLCBtZW0pOwo+ICsKPiArICAgIGQtPnZjcHUgPSB4 emFsbG9jX2FycmF5KHN0cnVjdCB2Y3B1ICosIGQtPm1heF92Y3B1cyk7Cj4gKyAgICBpZiAoICFk LT52Y3B1ICkKPiArICAgICAgICByZXR1cm4gLUVOT01FTTs7CgpkLT52Y3B1IGlzIGFscmVhZHkg YWxsb2NhdGVkIGJ5IGRvbWFpbl9jcmVhdGUuCgo+ICsgICAgaWYgKCB2Y3B1X2NyZWF0ZShkLCAw LCAwKSA9PSBOVUxMICkKPiArICAgICAgICByZXR1cm4gLUVOT01FTTsKPiArICAgIGQtPm1heF9w YWdlcyA9IH4wVTsKPiArCj4gKyAgICBraW5mby5kID0gZDsKPiArCj4gKyAgICByYyA9IGtlcm5l bF9wcm9iZSgma2luZm8sIG5vZGUpOwo+ICsgICAgaWYgKCByYyA8IDAgKQo+ICsgICAgICAgIHJl dHVybiByYzsKPiArCj4gKyNpZmRlZiBDT05GSUdfQVJNXzY0Cj4gKyAgICAvKiB0eXBlIG11c3Qg YmUgc2V0IGJlZm9yZSBhbGxvY2F0ZSBtZW1vcnkgKi8KPiArICAgIGQtPmFyY2gudHlwZSA9IGtp bmZvLnR5cGU7Cj4gKyNlbmRpZgo+ICsgICAgYWxsb2NhdGVfbWVtb3J5KGQsICZraW5mbyk7Cj4g Kwo+ICsgICAgcmV0dXJuIF9fY29uc3RydWN0X2RvbWFpbihkLCAma2luZm8pOwo+ICAgfQo+ICAg Cj4gICB2b2lkIF9faW5pdCBjcmVhdGVfZG9tVXModm9pZCkKPiBkaWZmIC0tZ2l0IGEveGVuL2Fy Y2gvYXJtL2tlcm5lbC5jIGIveGVuL2FyY2gvYXJtL2tlcm5lbC5jCj4gaW5kZXggZTViODIxMy4u MjIzOWEwNyAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC9hcm0va2VybmVsLmMKPiArKysgYi94ZW4v YXJjaC9hcm0va2VybmVsLmMKPiBAQCAtNDIxLDcgKzQyMSw4IEBAIHN0YXRpYyBpbnQgX19pbml0 IGtlcm5lbF96aW1hZ2UzMl9wcm9iZShzdHJ1Y3Qga2VybmVsX2luZm8gKmluZm8sCj4gICAgICAg cmV0dXJuIDA7Cj4gICB9Cj4gICAKPiAtaW50IF9faW5pdCBrZXJuZWxfcHJvYmUoc3RydWN0IGtl cm5lbF9pbmZvICppbmZvLCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRvbWFpbikKPiAraW50IF9f aW5pdCBrZXJuZWxfcHJvYmUoc3RydWN0IGtlcm5lbF9pbmZvICppbmZvLAo+ICsgICAgICAgICAg ICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRvbWFpbikKPiAgIHsK PiAgICAgICBzdHJ1Y3QgYm9vdG1vZHVsZSAqbW9kID0gTlVMTDsKPiAgICAgICBzdHJ1Y3QgYm9v dGNtZGxpbmUgKmNtZCA9IE5VTEw7Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9rZXJuZWwu aCBiL3hlbi9hcmNoL2FybS9rZXJuZWwuaAo+IGluZGV4IDRhNjUyODkuLjQzMjBmNzIgMTAwNjQ0 Cj4gLS0tIGEveGVuL2FyY2gvYXJtL2tlcm5lbC5oCj4gKysrIGIveGVuL2FyY2gvYXJtL2tlcm5l bC5oCj4gQEAgLTU1LDcgKzU1LDcgQEAgc3RydWN0IGtlcm5lbF9pbmZvIHsKPiAgICAqICAtPnR5 cGUKPiAgICAqICAtPmxvYWQgaG9vaywgYW5kIHNldHMgbG9hZGVyIHNwZWNpZmljIHZhcmlhYmxl cyAtPnppbWFnZQo+ICAgICovCj4gLWludCBrZXJuZWxfcHJvYmUoc3RydWN0IGtlcm5lbF9pbmZv ICppbmZvLCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRvbWFpbik7Cj4gK2ludCBrZXJuZWxfcHJv YmUoc3RydWN0IGtlcm5lbF9pbmZvICppbmZvLCBjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUg KmRvbWFpbik7Cj4gICAKPiAgIC8qCj4gICAgKiBMb2FkcyB0aGUga2VybmVsIGludG8gZ3Vlc3Qg UkFNLgo+IAoKQ2hlZXJzLAoKLS0gCkp1bGllbiBHcmFsbAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==