From: Paul Durrant <Paul.Durrant@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
"Keir (Xen.org)" <keir@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v4 1/2] x86/hvm/viridian: keep APIC assist page mapped...
Date: Thu, 17 Mar 2016 12:00:35 +0000 [thread overview]
Message-ID: <e51eb5306e8c4d0ebf2420df719c7318@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <56EAAA0B02000078000DDCEA@prv-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 17 March 2016 11:59
> To: Paul Durrant
> Cc: Andrew Cooper; xen-devel@lists.xenproject.org; Keir (Xen.org)
> Subject: Re: [PATCH v4 1/2] x86/hvm/viridian: keep APIC assist page
> mapped...
>
> >>> On 17.03.16 at 09:37, <paul.durrant@citrix.com> wrote:
> > +static void teardown_apic_assist(struct vcpu *v)
> > +{
> > + struct page_info *page = v->arch.hvm_vcpu.viridian.apic_assist.page;
> > + void *va = v->arch.hvm_vcpu.viridian.apic_assist.va;
> >
> > + if ( !va )
> > + return;
> > +
> > + v->arch.hvm_vcpu.viridian.apic_assist.va = NULL;
> > + v->arch.hvm_vcpu.viridian.apic_assist.page = NULL;
> > +
> > + unmap_domain_page_global(va);
> > put_page_and_type(page);
> > }
>
> The apic_assist.page field is needed only here, and is redundant
> with the va being stored (from which it can be derived via
> domain_page_map_to_mfn()). Please let's avoid needlessly
> growing struct vcpu.
>
Ok. I'll drop it then.
Paul
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-17 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 8:37 [PATCH v4 0/2] x86/hvm/viridian: APIC assist Paul Durrant
2016-03-17 8:37 ` [PATCH v4 1/2] x86/hvm/viridian: keep APIC assist page mapped Paul Durrant
2016-03-17 10:50 ` Andrew Cooper
2016-03-17 11:13 ` Paul Durrant
2016-03-17 11:58 ` Jan Beulich
2016-03-17 12:00 ` Paul Durrant [this message]
2016-03-17 8:37 ` [PATCH v4 2/2] x86/hvm/viridian: Enable APIC assist enlightenment Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e51eb5306e8c4d0ebf2420df719c7318@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).