xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Corneliu ZUZU <czuzu@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xen.org, Julien Grall <julien.grall@arm.com>,
	Tamas K Lengyel <tamas@tklengyel.com>
Subject: Re: [PATCH 1/7] minor (formatting) fixes
Date: Fri, 17 Jun 2016 13:46:15 +0300	[thread overview]
Message-ID: <e55f367f-f76d-9e90-6e5c-ccbd253a23c8@bitdefender.com> (raw)
In-Reply-To: <5763BD7802000078000F5E55@prv-mh.provo.novell.com>

On 6/17/2016 10:06 AM, Jan Beulich wrote:
>>>> On 16.06.16 at 21:19, <czuzu@bitdefender.com> wrote:
>> On 6/16/2016 5:24 PM, Jan Beulich wrote:
>>>>>> On 16.06.16 at 16:06, <czuzu@bitdefender.com> wrote:
>>>> --- a/xen/arch/x86/hvm/event.c
>>>> +++ b/xen/arch/x86/hvm/event.c
>>>> @@ -23,6 +23,7 @@
>>>>    
>>>>    #include <xen/vm_event.h>
>>>>    #include <asm/hvm/event.h>
>>>> +#include <asm/paging.h>
>>>>    #include <asm/monitor.h>
>>>>    #include <asm/vm_event.h>
>>>>    #include <public/vm_event.h>
>>>> diff --git a/xen/common/monitor.c b/xen/common/monitor.c
>>>> index d950a7c..b30857a 100644
>>>> --- a/xen/common/monitor.c
>>>> +++ b/xen/common/monitor.c
>>>> @@ -22,7 +22,6 @@
>>>>    #include <xen/monitor.h>
>>>>    #include <xen/sched.h>
>>>>    #include <xsm/xsm.h>
>>>> -#include <public/domctl.h>
>>>>    #include <asm/monitor.h>
>>>>    #include <asm/vm_event.h>
>>> These two adjustments clearly don't fit title / description. I certainly
>>> don't mind unnecessary inclusions to be dropped, but the addition of
>>> one clearly needs explanation (after all thing build fine without it).
>> Sorry, that was done out of reflex, should have stated the reasoning.
>> Generally, if:
>> - event.c includes event.h
>> - event.c needs paging.h
>> - event.h -doesn't need- paging.h
>> then I prefer to include paging.h in event.c, not in event.h (include
>> strictly -where- needed).
>> Also since xen/paging.h included asm/paging.h and event.c only needs the
>> asm/paging.h part, I also changed xen/paging.h inclusion -> asm/paging.h
>> inclusion (include strictly -what's- needed).
>> But I can revert that if you want me to (not that important and these
>> little things are better done with automatic tools anyway), or should I
>> leave the change and update the commit message?
> Well, I'd leave the ultimate decision to the maintainers, but I'd say
> this doesn't belong in a patch dealing with formatting issues. I.e.
> I'm fine with the cleanup, but either under a different title (and
> with at least an abbreviated version of what you said above), or
> in a separate patch. Considering that you appear to do the same
> in later patches, perhaps consolidating all the #include adjustments
> into one patch would a good idea?

I tend to prefer organizing what's easy to understand/minor first (to 
let reviewers get rid of those in a flash), so I'd prefer to leave it in 
this patch with the other minor fixes and update the commit message instead.
But either way it's fine by me.

>>>> --- a/xen/include/xen/vm_event.h
>>>> +++ b/xen/include/xen/vm_event.h
>>>> @@ -85,7 +85,6 @@ void vm_event_monitor_guest_request(void);
>>>>    
>>>>    #endif /* __VM_EVENT_H__ */
>>>>    
>>>> -
>>>>    /*
>>>>     * Local variables:
>>>>     * mode: C
>>> Why don't you remove the other stray blank line at once?
>> What stray line? Shouldn't there be -one- blank line between the #endif
>> and the local vars block?
>> Looking @ other files that rule seems to hold...
> Oh, you're right. I thought I had frequently seen it the other way
> around (and it would seem more logical to me), but I must have been
> misremembering.
>
> Jan
>
>

Thanks,
Corneliu.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-17 10:46 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 14:04 [PATCH 0/7] vm-event: Implement ARM support for control-register writes Corneliu ZUZU
2016-06-16 14:06 ` [PATCH 1/7] minor (formatting) fixes Corneliu ZUZU
2016-06-16 14:24   ` Jan Beulich
2016-06-16 19:19     ` Corneliu ZUZU
2016-06-17  7:06       ` Jan Beulich
2016-06-17 10:46         ` Corneliu ZUZU [this message]
2016-06-16 16:02   ` Tamas K Lengyel
2016-06-17  8:33     ` Corneliu ZUZU
2016-06-17  8:36       ` Razvan Cojocaru
2016-06-17  9:29         ` Andrew Cooper
2016-06-17  9:35           ` Jan Beulich
2016-06-17  9:33         ` Jan Beulich
2016-06-17  9:36           ` Razvan Cojocaru
2016-06-17  9:40             ` Jan Beulich
2016-06-17  9:42               ` Razvan Cojocaru
2016-06-17 19:05           ` Tamas K Lengyel
2016-06-16 14:07 ` [PATCH 2/7] vm-event: VM_EVENT_FLAG_DENY requires VM_EVENT_FLAG_VCPU_PAUSED Corneliu ZUZU
2016-06-16 16:11   ` Tamas K Lengyel
2016-06-17  8:43     ` Corneliu ZUZU
2016-06-21 11:26     ` Corneliu ZUZU
2016-06-21 15:09       ` Tamas K Lengyel
2016-06-22  8:34         ` Corneliu ZUZU
2016-06-16 14:08 ` [PATCH 3/7] vm-event: introduce vm_event_vcpu_enter Corneliu ZUZU
2016-06-16 14:51   ` Jan Beulich
2016-06-16 20:10     ` Corneliu ZUZU
2016-06-16 20:33       ` Razvan Cojocaru
2016-06-17 10:41         ` Corneliu ZUZU
2016-06-17  7:17       ` Jan Beulich
2016-06-17 11:13         ` Corneliu ZUZU
2016-06-17 11:27           ` Jan Beulich
2016-06-17 12:13             ` Corneliu ZUZU
2016-06-16 16:17   ` Tamas K Lengyel
2016-06-17  9:19     ` Corneliu ZUZU
2016-06-17  8:55   ` Julien Grall
2016-06-17 11:40     ` Corneliu ZUZU
2016-06-17 13:22       ` Julien Grall
2016-06-16 14:09 ` [PATCH 4/7] vm-event/x86: use vm_event_vcpu_enter properly Corneliu ZUZU
2016-06-16 15:00   ` Jan Beulich
2016-06-16 20:20     ` Corneliu ZUZU
2016-06-17  7:20       ` Jan Beulich
2016-06-17 11:23         ` Corneliu ZUZU
2016-06-16 16:27   ` Tamas K Lengyel
2016-06-17  9:24     ` Corneliu ZUZU
2016-06-16 14:10 ` [PATCH 5/7] x86: replace monitor_write_data.do_write with enum Corneliu ZUZU
2016-06-16 14:12 ` [PATCH 6/7] vm-event/arm: move hvm_event_cr->common vm_event_monitor_cr Corneliu ZUZU
2016-06-16 15:16   ` Jan Beulich
2016-06-17  8:25     ` Corneliu ZUZU
2016-06-17  8:38       ` Jan Beulich
2016-06-17 11:31         ` Corneliu ZUZU
2016-06-21  7:08       ` Corneliu ZUZU
2016-06-21  7:20         ` Jan Beulich
2016-06-21 15:22           ` Tamas K Lengyel
2016-06-22  6:33             ` Jan Beulich
2016-06-16 16:55   ` Tamas K Lengyel
2016-06-17 10:37     ` Corneliu ZUZU
2016-06-16 14:13 ` [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events Corneliu ZUZU
2016-06-16 14:26   ` Julien Grall
2016-06-16 19:24     ` Corneliu ZUZU
2016-06-16 21:28       ` Julien Grall
2016-06-17 11:46         ` Corneliu ZUZU
2016-06-16 16:49   ` Julien Grall
2016-06-17 10:36     ` Corneliu ZUZU
2016-06-17 13:18       ` Julien Grall
2016-06-22 16:35       ` Corneliu ZUZU
2016-06-22 17:17         ` Julien Grall
2016-06-22 18:39           ` Corneliu ZUZU
2016-06-22 19:37             ` Corneliu ZUZU
2016-06-22 19:41               ` Julien Grall
2016-06-23  5:31                 ` Corneliu ZUZU
2016-06-23  5:49                   ` Corneliu ZUZU
2016-06-23 11:11                     ` Julien Grall
2016-06-24  9:32                       ` Corneliu ZUZU
2016-06-23 11:00           ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e55f367f-f76d-9e90-6e5c-ccbd253a23c8@bitdefender.com \
    --to=czuzu@bitdefender.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=sstabellini@kernel.org \
    --cc=tamas@tklengyel.com \
    --cc=xen-devel@lists.xen.org \
    --subject='Re: [PATCH 1/7] minor (formatting) fixes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).