From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F891C4707F for ; Thu, 27 May 2021 05:54:31 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1641611C9 for ; Thu, 27 May 2021 05:54:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1641611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.132805.247650 (Exim 4.92) (envelope-from ) id 1lm8yG-0008Dw-Hq; Thu, 27 May 2021 05:54:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 132805.247650; Thu, 27 May 2021 05:54:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lm8yG-0008Dp-Dx; Thu, 27 May 2021 05:54:16 +0000 Received: by outflank-mailman (input) for mailman id 132805; Thu, 27 May 2021 05:54:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lm8yF-0008Dj-88 for xen-devel@lists.xenproject.org; Thu, 27 May 2021 05:54:15 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 39f3508b-7916-4481-bb2f-6ea2897ef43f; Thu, 27 May 2021 05:54:10 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 36E57218D6; Thu, 27 May 2021 05:54:09 +0000 (UTC) Received: from director2.suse.de (director2.suse-dmz.suse.de [192.168.254.72]) by imap.suse.de (Postfix) with ESMTPSA id 1BA4411A98; Thu, 27 May 2021 05:54:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39f3508b-7916-4481-bb2f-6ea2897ef43f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1622094849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cenKBmpg3IsK1rgGAIPzboMPz4WWFEeK3q+oV059KHM=; b=eXJClXW74ampbup5vQmG5n9z2tdXGPb3KrBkLaSy2W+mS7Y+joYRnfZGZ64diLtpFVcl3V 0Bdv+D7+5c5sLYz2MKo4vCRs+7D2UR21YtJj884J5GGp0a50sJvDGBdWxveA2JyAfTHVUq ggXjpbYXQ+pxW40EZU2Ymh18K11eFeI= Subject: Re: [PATCH 05/13] xenpm: Change get-cpufreq-para output for internal From: Jan Beulich To: Jason Andryuk Cc: Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210503192810.36084-1-jandryuk@gmail.com> <20210503192810.36084-6-jandryuk@gmail.com> Message-ID: Date: Thu, 27 May 2021 07:54:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.05.2021 17:21, Jan Beulich wrote: > On 03.05.2021 21:28, Jason Andryuk wrote: >> --- a/tools/misc/xenpm.c >> +++ b/tools/misc/xenpm.c >> @@ -711,6 +711,7 @@ void start_gather_func(int argc, char *argv[]) >> /* print out parameters about cpu frequency */ >> static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) >> { >> + bool internal = strstr(p_cpufreq->scaling_governor, "internal"); > > Like suggested for the hypervisor, perhaps better check for names > ending in "-internal"? Thinking about it more, the adjustments you make aren't necessarily applicable to other hypothetical internal governors, are they? In which case you rather want to check for hwp specifically. Jan