From: Jan Beulich <jbeulich@suse.com>
To: vrd@amazon.com
Cc: "'Julien Grall'" <julien@xen.org>,
paul@xen.org, "'Andrew Cooper'" <andrew.cooper3@citrix.com>,
"'Varad Gautam'" <vrd@amazon.de>,
xen-devel@lists.xenproject.org,
"'Roger Pau Monné'" <roger.pau@citrix.com>
Subject: Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs
Date: Tue, 28 Apr 2020 14:18:34 +0200 [thread overview]
Message-ID: <e69ea420-d32d-0c6b-5bb8-e02f750bc11e@suse.com> (raw)
In-Reply-To: <8bcd4d23-cb03-bb3e-360e-4213cd2d7b49@amazon.com>
On 28.04.2020 13:58, vrd@amazon.com wrote:
> On 3/10/20 3:19 PM, Jan Beulich wrote:
>> On 09.03.2020 18:47, Paul Durrant wrote:
>>> Please suggest code if you think it ought to be done differentely. I tried.
>> How about this? It's admittedly more code, but imo less ad hoc.
>> I've smoke tested it, but I depend on you or Varad to check that
>> it actually addresses the reported issue.
>>
>> Jan
>>
>> x86/pass-through: avoid double IRQ unbind during domain cleanup
>
>
> I have tested that this patch prevents __pirq_guest_unbind on an already-unbound pirq
> during the continuation call for domain_kill -ERESTART, by using a modified xen that
> forces an -ERESTART from pirq_guest_unbind to create the continuation. It fixes the
> underlying issue.
>
> Tested-by: Varad Gautam <vrd@amazon.de>
Thanks much; I'll formally submit the patch then.
Jan
prev parent reply other threads:[~2020-04-28 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 16:02 [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs paul
2020-03-09 16:29 ` Jan Beulich
2020-03-09 17:47 ` Paul Durrant
2020-03-10 11:23 ` Jan Beulich
2020-03-10 12:36 ` Paul Durrant
2020-03-10 13:38 ` Jan Beulich
2020-03-10 14:19 ` Jan Beulich
2020-03-17 15:23 ` Paul Durrant
2020-03-31 7:40 ` Jan Beulich
2020-03-31 11:51 ` Paul Durrant
2020-04-23 11:08 ` Jan Beulich
2020-04-23 15:14 ` Paul Durrant
2020-04-28 11:58 ` vrd
2020-04-28 12:18 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e69ea420-d32d-0c6b-5bb8-e02f750bc11e@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=vrd@amazon.com \
--cc=vrd@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).