From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien@xen.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>, <jmorris@namei.org>,
<sashal@kernel.org>, <linux-kernel@vger.kernel.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<steve.capper@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<marc.zyngier@arm.com>, <james.morse@arm.com>,
<vladimir.murzin@arm.com>, <mark.rutland@arm.com>,
<tglx@linutronix.de>, <gregkh@linuxfoundation.org>,
<allison@lohutok.net>, <info@metux.net>,
<alexios.zavras@intel.com>, <sstabellini@kernel.org>,
<boris.ostrovsky@oracle.com>, <jgross@suse.com>,
<stefan@agner.ch>, <yamada.masahiro@socionext.com>,
<xen-devel@lists.xenproject.org>, <linux@armlinux.org.uk>
Subject: Re: [Xen-devel] [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd_call
Date: Fri, 29 Nov 2019 15:09:53 +0000 [thread overview]
Message-ID: <e785a585-8b71-8a49-285e-2bcb1437500b@citrix.com> (raw)
In-Reply-To: <957930d0-8317-9086-c7a1-8de857f358c2@xen.org>
On 29/11/2019 15:05, Julien Grall wrote:
> Hi,
>
> On 27/11/2019 18:44, Pavel Tatashin wrote:
>> diff --git a/arch/arm64/include/asm/xen/hypercall.h
>> b/arch/arm64/include/asm/xen/hypercall.h
>> index 3522cbaed316..1a74fb28607f 100644
>> --- a/arch/arm64/include/asm/xen/hypercall.h
>> +++ b/arch/arm64/include/asm/xen/hypercall.h
>> @@ -1 +1,29 @@
>> +#ifndef _ASM_ARM64_XEN_HYPERCALL_H
>> +#define _ASM_ARM64_XEN_HYPERCALL_H
>> #include <xen/arm/hypercall.h>
>> +#include <linux/uaccess.h>
>> +
>> +static inline long privcmd_call(unsigned int call, unsigned long a1,
>> + unsigned long a2, unsigned long a3,
>> + unsigned long a4, unsigned long a5)
>
> I realize that privcmd_call is the only hypercall using Software PAN
> at the moment. However, dm_op needs the same as hypercall will be
> issued from userspace as well.
And dm_op() won't be the only example as we continue in cleaning up the
gaping hole that is privcmd.
> So I was wondering whether we should create a generic function (e.g.
> do_xen_hypercall() or do_xen_user_hypercall()) to cover the two
> hypercalls?
Probably a good idea.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-11-29 15:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 18:44 [Xen-devel] [PATCH 0/3] Use C inlines for uaccess Pavel Tatashin
2019-11-27 18:44 ` [Xen-devel] [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd_call Pavel Tatashin
2019-11-29 15:05 ` Julien Grall
2019-11-29 15:09 ` Andrew Cooper [this message]
2019-12-04 17:55 ` Pavel Tatashin
2019-12-04 17:58 ` Pavel Tatashin
2019-11-27 18:44 ` [Xen-devel] [PATCH 2/3] arm64: remove uaccess_ttbr0 asm macros from cache functions Pavel Tatashin
2019-11-28 14:51 ` Mark Rutland
2019-12-04 20:50 ` Pavel Tatashin
2019-11-27 18:44 ` [Xen-devel] [PATCH 3/3] arm64: remove the rest of asm-uaccess.h Pavel Tatashin
2019-11-27 18:46 ` [Xen-devel] [PATCH 0/3] Use C inlines for uaccess Pavel Tatashin
-- strict thread matches above, loose matches on Subject: below --
2019-11-21 18:48 Pavel Tatashin
2019-11-21 18:48 ` [Xen-devel] [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd_call Pavel Tatashin
2019-11-22 0:22 ` Russell King - ARM Linux admin
2019-11-22 0:30 ` Pavel Tatashin
2019-11-22 0:34 ` Russell King - ARM Linux admin
2019-11-22 0:35 ` Russell King - ARM Linux admin
2019-11-22 0:39 ` Pavel Tatashin
2019-11-22 0:53 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e785a585-8b71-8a49-285e-2bcb1437500b@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=boris.ostrovsky@oracle.com \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=james.morse@arm.com \
--cc=jgross@suse.com \
--cc=jmorris@namei.org \
--cc=julien@xen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pasha.tatashin@soleen.com \
--cc=sashal@kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefan@agner.ch \
--cc=steve.capper@arm.com \
--cc=tglx@linutronix.de \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).