From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A603C433ED for ; Wed, 12 May 2021 22:16:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4A02613FE for ; Wed, 12 May 2021 22:16:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4A02613FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.126439.238025 (Exim 4.92) (envelope-from ) id 1lgx9H-0006tz-R5; Wed, 12 May 2021 22:16:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 126439.238025; Wed, 12 May 2021 22:16:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgx9H-0006ts-Nz; Wed, 12 May 2021 22:16:11 +0000 Received: by outflank-mailman (input) for mailman id 126439; Wed, 12 May 2021 22:16:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgx9F-0006tm-JH for xen-devel@lists.xenproject.org; Wed, 12 May 2021 22:16:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgx9D-0004dq-KC; Wed, 12 May 2021 22:16:07 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lgx9D-0006E2-E6; Wed, 12 May 2021 22:16:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=/Rnz7krNnHyU5Ry0uAiKBQ2Yb01yUAQ3dItD4+uNPXQ=; b=2EinrVlU+CvbOMnyLYV04tc4WX ziGDwPXsGYIvCcTf9oAOwM0gFJeJ4luuk3lARk2HJLf7rYy9aCUaX5+5vOCpeMc/KK7jHRkWVzdPo TkJfljBp4YrGC4DO6Wr2IZkre4/IcsuynzQ7zC6HYqq4uLjooOJWyPE7rNgqf5nCy0wA=; Subject: Re: [PATCH RFCv2 02/15] xen/arm: lpae: Use the generic helpers to defined the Xen PT helpers To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Wei.Chen@arm.com, Henry.Wang@arm.com, Penny.Zheng@arm.com, Bertrand.Marquis@arm.com, Julien Grall , Volodymyr Babchuk References: <20210425201318.15447-1-julien@xen.org> <20210425201318.15447-3-julien@xen.org> <94e364a7-de40-93ab-6cde-a2f493540439@xen.org> From: Julien Grall Message-ID: Date: Wed, 12 May 2021 23:16:05 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 12/05/2021 22:30, Stefano Stabellini wrote: > On Wed, 12 May 2021, Julien Grall wrote: >>>> +#define LPAE_SHIFT LPAE_SHIFT_GS(PAGE_SHIFT) >>>> +#define LPAE_ENTRIES LPAE_ENTRIES_GS(PAGE_SHIFT) >>>> +#define LPAE_ENTRY_MASK LPAE_ENTRY_MASK_GS(PAGE_SHIFT) >>>> >>>> +#define LEVEL_SHIFT(lvl) LEVEL_SHIFT_GS(PAGE_SHIFT, lvl) >>>> +#define LEVEL_ORDER(lvl) LEVEL_ORDER_GS(PAGE_SHIFT, lvl) >>>> +#define LEVEL_SIZE(lvl) LEVEL_SIZE_GS(PAGE_SHIFT, lvl) >>>> +#define LEVEL_MASK(lvl) (~(LEVEL_SIZE(lvl) - 1)) >>> >>> I would avoid adding these 4 macros. It would be OK if they were just >>> used within this file but lpae.h is a header: they could end up be used >>> anywhere in the xen/ code and they have a very generic name. My >>> suggestion would be to skip them and just do: >> >> Those macros will be used in follow-up patches. They are pretty useful to >> avoid introduce static array with the different information for each level. >> >> Would prefix them with XEN_ be better? > > Maybe. The concern I have is that there are multiple page granularities > (4kb, 16kb, etc) and multiple page sizes (4kb, 2mb, etc). If I just see > LEVEL_ORDER it is not immediately obvious what granularity and what size > we are talking about. I am a bit puzzled with your answer. AFAIU, you are happy with the existing macros (THIRD_*, SECOND_*) but not with the new macros. In reality, there is no difference because THIRD_* doesn't tell you the exact size but only "this is a level 3 mapping". So can you clarify what you are after? IOW is it reworking the current naming scheme? Cheers, -- Julien Grall