From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 2/2] libelf: improve PVH elfnote parsing
Date: Thu, 20 May 2021 14:37:09 +0200 [thread overview]
Message-ID: <e9633187-42c1-e922-70b9-30c0b5a862b8@suse.com> (raw)
In-Reply-To: <20210520123012.89855-3-roger.pau@citrix.com>
On 20.05.2021 14:30, Roger Pau Monne wrote:
> Pass an hvm boolean parameter to the elf note parsing and checking
> routines, so that better checking can be done in case libelf is
> dealing with an hvm container.
>
> elf_xen_note_check shouldn't return early unless PHYS32_ENTRY is set
> and the container is of type HVM, or else the loader and version
> checks would be avoided for kernels intended to be booted as PV but
> that also have PHYS32_ENTRY set.
>
> Adjust elf_xen_addr_calc_check so that the virtual addresses are
> actually physical ones (by setting virt_base and elf_paddr_offset to
> zero) when the container is of type HVM, as that container is always
> started with paging disabled.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
With the one hunk moved to patch 1
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Jan
prev parent reply other threads:[~2021-05-20 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:30 [PATCH v3 0/2] libelf: small fixes for PVH Roger Pau Monne
2021-05-20 12:30 ` [PATCH v3 1/2] libelf: don't attempt to parse __xen_guest " Roger Pau Monne
2021-05-20 12:35 ` Jan Beulich
2021-05-21 13:31 ` Jan Beulich
2021-05-28 7:21 ` Jan Beulich
2021-05-20 12:30 ` [PATCH v3 2/2] libelf: improve PVH elfnote parsing Roger Pau Monne
2021-05-20 12:37 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9633187-42c1-e922-70b9-30c0b5a862b8@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).