From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8066C4338F for ; Thu, 19 Aug 2021 13:34:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABB83610A1 for ; Thu, 19 Aug 2021 13:34:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ABB83610A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.168812.308249 (Exim 4.92) (envelope-from ) id 1mGiBX-0006xi-Kk; Thu, 19 Aug 2021 13:34:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 168812.308249; Thu, 19 Aug 2021 13:34:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGiBX-0006xb-Hj; Thu, 19 Aug 2021 13:34:19 +0000 Received: by outflank-mailman (input) for mailman id 168812; Thu, 19 Aug 2021 13:34:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGiBW-0006xV-NF for xen-devel@lists.xenproject.org; Thu, 19 Aug 2021 13:34:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGiBV-000091-UN; Thu, 19 Aug 2021 13:34:17 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mGiBV-0001A0-OQ; Thu, 19 Aug 2021 13:34:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=jKKbfKDimSAdM6dne2I4mysQzoy0odn7FsqRU/fdx7E=; b=BNbvU5jS3V84yifMXzhCyrpPyt f/pQHBSdo5GTMf9tFd8HUBaK/p4wTz8gHIi0/RY5NlfyEQm7H3AdgEZwWuEcdeXjSJfwlRKR2miuk 8sDCw6P2lQJh1fvYcJ5dUAe0MYTc0varCZQDZlRjOofPebrWKi/wPvyM9sKGtpJ2Nd4k=; Subject: Re: [XEN RFC PATCH 07/40] xen/arm: use !CONFIG_NUMA to keep fake NUMA API To: Wei Chen , xen-devel@lists.xenproject.org, sstabellini@kernel.org, jbeulich@suse.com Cc: Bertrand.Marquis@arm.com References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-8-wei.chen@arm.com> From: Julien Grall Message-ID: Date: Thu, 19 Aug 2021 14:34:16 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210811102423.28908-8-wei.chen@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Wei, On 11/08/2021 11:23, Wei Chen wrote: > Only Arm64 supports NUMA, the CONFIG_NUMA could not be > enabled for Arm32. What do you mean by "could not be enabled"? > Even in Arm64, users still can disable > the CONFIG_NUMA through Kconfig option. In this case, keep > current fake NUMA API, will make Arm code still can work > with NUMA aware memory allocation and scheduler. > > Signed-off-by: Wei Chen > --- > xen/include/asm-arm/numa.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/xen/include/asm-arm/numa.h b/xen/include/asm-arm/numa.h > index 31a6de4e23..ab9c4a2448 100644 > --- a/xen/include/asm-arm/numa.h > +++ b/xen/include/asm-arm/numa.h > @@ -5,6 +5,8 @@ > > typedef u8 nodeid_t; > > +#if !defined(CONFIG_NUMA) NIT: We tend to use #ifndef rather than #if !defined(...) > + > /* Fake one node for now. See also node_online_map. */ > #define cpu_to_node(cpu) 0 > #define node_to_cpumask(node) (cpu_online_map) > @@ -25,6 +27,8 @@ extern mfn_t first_valid_mfn; > #define node_start_pfn(nid) (mfn_x(first_valid_mfn)) > #define __node_distance(a, b) (20) > > +#endif > + > #endif /* __ARCH_ARM_NUMA_H */ > /* > * Local variables: > Cheers, -- Julien Grall