From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C78C433E0 for ; Mon, 18 May 2020 15:05:47 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD0F220671 for ; Mon, 18 May 2020 15:05:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD0F220671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jahKQ-0001j1-1c; Mon, 18 May 2020 15:05:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jahKP-0001iw-HK for xen-devel@lists.xenproject.org; Mon, 18 May 2020 15:05:17 +0000 X-Inumbo-ID: fab79d6d-9918-11ea-a870-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fab79d6d-9918-11ea-a870-12813bfff9fa; Mon, 18 May 2020 15:05:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BA5BAACB1; Mon, 18 May 2020 15:05:17 +0000 (UTC) Subject: Re: [PATCH v3 2/2] x86/idle: prevent entering C6 with in service interrupts on Intel To: Roger Pau Monne References: <20200515135802.63853-1-roger.pau@citrix.com> <20200515135802.63853-3-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Mon, 18 May 2020 17:05:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200515135802.63853-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 15.05.2020 15:58, Roger Pau Monne wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -652,6 +652,15 @@ Specify the size of the console debug trace buffer. By specifying `cpu:` > additionally a trace buffer of the specified size is allocated per cpu. > The debug trace feature is only enabled in debugging builds of Xen. > > +### disable-c6-errata Hmm, yes please - a disable for errata! ;-) How about "avoid-c6-errata", and then perhaps as a sub-option to "cpuidle="? (If we really want a control for this in the first place.) > @@ -573,10 +574,40 @@ bool errata_c6_eoi_workaround(void) > INTEL_FAM6_MODEL(0x2f), > { } > }; > + /* > + * Errata BDX99, CLX30, SKX100, CFW125, BDF104, BDH85, BDM135, KWB131: > + * A Pending Fixed Interrupt May Be Dispatched Before an Interrupt of > + * The Same Priority Completes. > + * > + * Resuming from C6 Sleep-State, with Fixed Interrupts of the same > + * priority queued (in the corresponding bits of the IRR and ISR APIC > + * registers), the processor may dispatch the second interrupt (from > + * the IRR bit) before the first interrupt has completed and written to > + * the EOI register, causing the first interrupt to never complete. > + */ > + const static struct x86_cpu_id isr_errata[] = { Same nit as for patch 1 here. Jan