From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B252C433B4 for ; Mon, 12 Apr 2021 09:50:48 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE38C6121E for ; Mon, 12 Apr 2021 09:50:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE38C6121E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.108874.207733 (Exim 4.92) (envelope-from ) id 1lVtDF-0002CO-As; Mon, 12 Apr 2021 09:50:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 108874.207733; Mon, 12 Apr 2021 09:50:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lVtDF-0002CH-6q; Mon, 12 Apr 2021 09:50:33 +0000 Received: by outflank-mailman (input) for mailman id 108874; Mon, 12 Apr 2021 09:50:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lVtDD-0002CC-Mb for xen-devel@lists.xenproject.org; Mon, 12 Apr 2021 09:50:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c64d6431-4f9b-440a-83c6-f61235a847f6; Mon, 12 Apr 2021 09:50:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F0910AF49; Mon, 12 Apr 2021 09:50:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c64d6431-4f9b-440a-83c6-f61235a847f6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1618221030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H6kWfMg0gUyGaa9RXENbF9xOy3qyixJussWEJJGr+s8=; b=SbLG6rZpDZQulq1CWHptyOPnbkkyEjKFVzdSRtXzE67lJXOPSYe8RRp2jO1s7kSC0/St8D 6fh9afusDJuoaa8/PIJJByggxOGRh/g8aFjNkP2OjiTBsx9tr5srSDp5e17fwoQ6f2gPJ8 7V4v5u9iiPRcJ/rF+IG8FPcwFR/VHDA= Subject: Re: [PATCH 3/3] xen-pciback: simplify vpci's find hook To: Boris Ostrovsky Cc: Juergen Gross , Konrad Wilk , "xen-devel@lists.xenproject.org" References: <158273a2-d1b9-3545-b25d-affca867376c@suse.com> From: Jan Beulich Message-ID: Date: Mon, 12 Apr 2021 11:50:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09.04.2021 23:45, Boris Ostrovsky wrote: > > On 4/7/21 10:37 AM, Jan Beulich wrote: >> There's no point in comparing SBDF - we can simply compare the struct >> pci_dev pointers. If they weren't the same for a given device, we'd have >> bigger problems from having stored a stale pointer. >> >> Signed-off-by: Jan Beulich > > > Reviewed-by: Boris Ostrovsky Thanks. As the 1st patch of this series still looks to have an unclear disposition (unless not getting back a reply on my responses to your comments means silent agreement), I can't predict yet when I'd be able to submit v2. Hence I'd like to point out that this patch is independent of the former two, and hence would need to wait further if you wanted to apply it. After all this one (unlike the other two) is merely cleanup, and hence would rather want to go in during a merge window. Jan