From: Jan Beulich <jbeulich@suse.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: Nick Rosbrook <rosbrookn@gmail.com>, Wei Liu <wl@xen.org>,
Anthony Perard <anthony.perard@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y
Date: Wed, 26 Aug 2020 09:41:45 +0200 [thread overview]
Message-ID: <ea3ab742-84e0-1e98-87ad-2e38b2224917@suse.com> (raw)
In-Reply-To: <B99E1A82-FBE8-4EE3-943A-4384BA504184@citrix.com>
On 25.08.2020 12:37, George Dunlap wrote:
> As an explanation, there are a combination of things. You proposed A (remove the dependency), Ian proposed B (use move-if-changed), but we’re hoping to do C (have an external tree) before the next release. I haven’t had the time to look into either B or C (nor, unfortunately, to review Nick’s submissions to other parts of the code — sorry Nick!); but I’ve still been reluctant to go for A.
>
> I think basically, unless someone is ready to tackle B or C immediately, we should just check in Jan’s fix (or probably better, just revert the patch that introduced the dependency). It will be annoying to have to potentially fix up the generated golang bindings, but that puts the incentives in the right place.
One additional aspect to consider is that I ran into the issue actually
in a 4.14 tree (because it just so happened that the timestamps of the
involved files were "right" for the problem to be hit), i.e. whatever
we decide to do will also end up needing backporting. To me this looks
to make A less attractive.
Jan
next prev parent reply other threads:[~2020-08-26 7:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 8:06 [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y Jan Beulich
2020-08-04 14:16 ` Wei Liu
2020-08-04 15:22 ` Nick Rosbrook
2020-08-04 15:30 ` Jan Beulich
2020-08-04 15:50 ` Wei Liu
2020-08-04 15:53 ` Jan Beulich
2020-08-04 15:57 ` Wei Liu
2020-08-04 16:02 ` Jan Beulich
2020-08-04 16:41 ` Nick Rosbrook
2020-08-05 6:35 ` Jan Beulich
2020-08-05 9:55 ` Ian Jackson
2020-08-10 15:17 ` George Dunlap
2020-08-24 13:11 ` Jan Beulich
2020-08-24 14:58 ` Nick Rosbrook
2020-08-25 6:47 ` Jan Beulich
2020-08-25 10:37 ` George Dunlap
2020-08-25 14:57 ` Nick Rosbrook
2020-08-26 7:41 ` Jan Beulich [this message]
2020-08-26 10:33 ` George Dunlap
2020-08-26 11:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3ab742-84e0-1e98-87ad-2e38b2224917@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=rosbrookn@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).