From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/oprofile: remove compat accessors usage from backtrace
Date: Fri, 23 Apr 2021 14:54:09 +0200 [thread overview]
Message-ID: <ea669904-a7f4-fdc7-80c0-6a88d61e655e@suse.com> (raw)
In-Reply-To: <148bd895-17bc-188d-e2e6-c1604400c5a3@citrix.com>
On 23.04.2021 14:51, Andrew Cooper wrote:
> On 23/04/2021 13:35, Roger Pau Monne wrote:
>> Remove the unneeded usage of the compat layer to copy frame pointers
>> from guest address space. Instead just use raw_copy_from_guest.
>>
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> ---
>> Just build tested. Note sure I'm missing something, since using the
>> compat layer here was IMO much more complicated than just using the
>> raw accessors.
>
> Thankyou, and yes - I agree. The logic was unnecessarily complicated.
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Needs a fixes tag, but can be sorted on commit.
Fixes what?
Jan
next prev parent reply other threads:[~2021-04-23 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 12:35 [PATCH] x86/oprofile: remove compat accessors usage from backtrace Roger Pau Monne
2021-04-23 12:51 ` Andrew Cooper
2021-04-23 12:54 ` Jan Beulich [this message]
2021-04-23 12:53 ` Jan Beulich
2021-04-23 13:40 ` Andrew Cooper
2021-04-23 13:51 ` Roger Pau Monné
2021-04-23 13:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea669904-a7f4-fdc7-80c0-6a88d61e655e@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).