From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B031C433B4 for ; Thu, 15 Apr 2021 14:19:10 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABD0D6113D for ; Thu, 15 Apr 2021 14:19:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABD0D6113D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.111249.212741 (Exim 4.92) (envelope-from ) id 1lX2pg-00071t-4S; Thu, 15 Apr 2021 14:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 111249.212741; Thu, 15 Apr 2021 14:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lX2pg-00071m-1V; Thu, 15 Apr 2021 14:19:00 +0000 Received: by outflank-mailman (input) for mailman id 111249; Thu, 15 Apr 2021 14:18:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lX2pe-00071g-UM for xen-devel@lists.xenproject.org; Thu, 15 Apr 2021 14:18:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lX2pd-0001LK-JK; Thu, 15 Apr 2021 14:18:57 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lX2pd-00065b-CY; Thu, 15 Apr 2021 14:18:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=LQ3C8SV37WgeSukHdHPFX7tGilymL5AjEM/hlxsdtC8=; b=5DqDs0sVjK3MO5VsjShgsH9MAZ VsAOBVPkcxrPz1gOsK3L5eJhGWqML/ZP4yFWPecR4MDQGgQFlaMrKdgQsqxk1Js8aRrV8m2umkudr 6rHLH3lhmLQeigOTXPHkLdMZlG+Xq0lGHJ4AXI0VOenDpnJgEFoD3pIt4nqigr9OfLdw=; Subject: Re: [PATCH v3 12/15] unxz: replace INIT{,DATA} and STATIC To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <2db91183-a7de-0c43-2fef-feb3523ed19b@suse.com> <4e0a0db2-db34-a738-2f5e-1d5cd2c37e19@suse.com> From: Julien Grall Message-ID: Date: Thu, 15 Apr 2021 15:18:55 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 15/04/2021 15:16, Jan Beulich wrote: > On 15.04.2021 13:58, Julien Grall wrote: >> On 26/01/2021 09:52, Jan Beulich wrote: >>> --- a/xen/common/decompress.h >>> +++ b/xen/common/decompress.h >>> @@ -9,7 +9,6 @@ >>> >>> #define STATIC static >>> #define INIT __init >>> -#define INITDATA __initdata >>> >>> #define malloc xmalloc_bytes >>> #define free xfree >>> @@ -21,7 +20,6 @@ >>> >>> #define STATIC static >>> #define INIT >>> -#define INITDATA >> >> Shouldn't the two changes be part of patch #14? > > One could do it that way, sure, but the last uses are gone here, > and hence I wanted to get rid of this one item right away. AFAICT, the same is true for STATIC and INIT. So it doesn't sense to not be consistent in the way you treat them. Cheers, -- Julien Grall