From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2DE6C4361B for ; Mon, 7 Dec 2020 09:59:43 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74EE22310B for ; Mon, 7 Dec 2020 09:59:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74EE22310B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.46056.81689 (Exim 4.92) (envelope-from ) id 1kmDIq-0001t7-KQ; Mon, 07 Dec 2020 09:59:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 46056.81689; Mon, 07 Dec 2020 09:59:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmDIq-0001t0-HT; Mon, 07 Dec 2020 09:59:32 +0000 Received: by outflank-mailman (input) for mailman id 46056; Mon, 07 Dec 2020 09:59:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmDIp-0001su-GM for xen-devel@lists.xenproject.org; Mon, 07 Dec 2020 09:59:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 89fa7183-07bb-4977-b10b-62d5321293f1; Mon, 07 Dec 2020 09:59:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1DFCFAD6B; Mon, 7 Dec 2020 09:59:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89fa7183-07bb-4977-b10b-62d5321293f1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607335170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bdqn2agfR32U8qSo2/yxfyc/n46s4Yiha5+sGmTNiQg=; b=YYTseKZZSegTUyX5UUTIkzLAMUDYNyzz0lk+DLtFXNOboaY05Ayj4Yp4oK6X1RxQF/X5QV BWtEB+6Z/V6yD6jSsA5CWcPpKZW4/GyLbzy5j9i/lA0nSstwn69+8F8pb/JjnETQHoYYub PSNukv802wbcxDQOCbT/9jaGyOBjHjU= Subject: Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: George Dunlap , Dario Faggioli , Andrew Cooper , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20201201082128.15239-1-jgross@suse.com> <20201201082128.15239-5-jgross@suse.com> From: Jan Beulich Message-ID: Date: Mon, 7 Dec 2020 10:59:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01.12.2020 10:01, Jürgen Groß wrote: > On 01.12.20 09:55, Jan Beulich wrote: >> On 01.12.2020 09:21, Juergen Gross wrote: >>> --- a/xen/common/sched/private.h >>> +++ b/xen/common/sched/private.h >>> @@ -505,8 +505,8 @@ static inline void sched_unit_unpause(const struct sched_unit *unit) >>> >>> struct cpupool >>> { >>> - int cpupool_id; >>> -#define CPUPOOLID_NONE (-1) >>> + unsigned int cpupool_id; >>> +#define CPUPOOLID_NONE (~0U) >> >> How about using XEN_SYSCTL_CPUPOOL_PAR_ANY here? Furthermore, >> together with the remark above, I think you also want to consider >> the case of sizeof(unsigned int) > sizeof(uint32_t). > > With patch 5 this should be completely fine. I don't think so, as there still will be CPUPOOLID_NONE != XEN_SYSCTL_CPUPOOL_PAR_ANY in the mentioned case. Jan