From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21775C433DF for ; Wed, 19 Aug 2020 09:18:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEA4C20639 for ; Wed, 19 Aug 2020 09:18:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEA4C20639 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k8KEq-00035Z-O6; Wed, 19 Aug 2020 09:18:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k8KEp-00035U-B5 for xen-devel@lists.xenproject.org; Wed, 19 Aug 2020 09:18:31 +0000 X-Inumbo-ID: 6ec1302e-4dea-47fb-86f2-ed5edd002c4d Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6ec1302e-4dea-47fb-86f2-ed5edd002c4d; Wed, 19 Aug 2020 09:18:29 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7649FAD80; Wed, 19 Aug 2020 09:18:54 +0000 (UTC) Subject: Re: [PATCH] xen: Introduce cmpxchg64() and guest_cmpxchg64() To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Julien Grall , xen-devel@lists.xenproject.org, Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , Wei Liu , Oleksandr Tyshchenko References: <20200815172143.1327-1-julien@xen.org> <20200817092406.GO975@Air-de-Roger> <20200817103306.GA828@Air-de-Roger> <20200817114730.GB828@Air-de-Roger> From: Jan Beulich Message-ID: Date: Wed, 19 Aug 2020 11:18:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200817114730.GB828@Air-de-Roger> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 17.08.2020 13:50, Roger Pau Monné wrote: > FWIW x86 already has a specific handler for 128bit values: cmpxchg16b. > Maybe it would be better to name this cmpxchg8b? Or rename the > existing one to cmpxchg128 for coherence. cmpxchg16b() is named after the underlying insn. If we gain cmpxchg64(), then I agree this one wants renaming to cmpxchg128() at the same time. Jan