From: David Woodhouse <dwmw2@infradead.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org, "Wei Liu" <wl@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image
Date: Mon, 02 Sep 2019 14:52:31 +0100 [thread overview]
Message-ID: <ecd28e008684e723bf9680419acba3b377206c94.camel@infradead.org> (raw)
In-Reply-To: <e7d32e0e-62fa-df10-c27d-36bd482e7a88@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1117 bytes --]
On Mon, 2019-09-02 at 15:47 +0200, Jan Beulich wrote:
> On 02.09.2019 14:51, David Woodhouse wrote:
> > On Mon, 2019-09-02 at 09:44 +0200, Jan Beulich wrote:
> > > Right, just one pair should survive. And seeing how things work before
> > > this series I think it indeed should be linker script symbols only.
> > > And then the ALIGN() ahead of the "start" ones should stay, but there's
> > > no need for one on the "end" ones (again as is currently the case).
> >
> > If we don't align the end symbol then we need to go back to rounding up
> > the length with ((boot_trampoline_end - boot_trampoline_start) + 3) / 4
> > again though, right?
>
> Wait - we've been talking about the *_rel sections / tables here,
> haven't we? All entries of these tables ought to be of equal size,
> and hence alignment of a table's "end" label automatically matches
> the size of the table entries.
The specific one we were taking about just then was
bootdata_{start,end} which is the data itself to be copied up/down, not
the relocations.
The _rel sections indeed need no alignment at the end, as you say.
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-02 13:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 16:35 [Xen-devel] [PATCH v3 0/5] Clean up x86_64 boot code David Woodhouse
2019-08-21 16:35 ` [Xen-devel] [PATCH v3 1/5] x86/boot: Only jump into low trampoline code for real-mode boot David Woodhouse
2019-08-21 16:35 ` [Xen-devel] [PATCH v3 2/5] x86/boot: Split bootsym() into four types of relocations David Woodhouse
2019-08-30 15:10 ` Jan Beulich
2019-08-30 16:12 ` David Woodhouse
2019-09-02 7:37 ` Jan Beulich
2019-08-21 16:35 ` [Xen-devel] [PATCH v3 3/5] x86/boot: Rename trampoline_{start, end} to boot_trampoline_{start, end} David Woodhouse
2019-08-21 16:35 ` [Xen-devel] [PATCH v3 4/5] x86/boot: Copy 16-bit boot variables back up to Xen image David Woodhouse
2019-08-30 15:43 ` Jan Beulich
2019-08-30 16:25 ` David Woodhouse
2019-09-02 7:44 ` Jan Beulich
2019-09-02 12:51 ` David Woodhouse
2019-09-02 13:47 ` Jan Beulich
2019-09-02 13:52 ` David Woodhouse [this message]
2019-09-02 14:10 ` Jan Beulich
2019-08-21 16:35 ` [Xen-devel] [PATCH v3 5/5] x86/boot: Do not use trampoline for no-real-mode boot paths David Woodhouse
2019-09-02 8:54 ` Jan Beulich
2019-08-30 14:25 ` [Xen-devel] [PATCH v3 1/5] x86/boot: Only jump into low trampoline code for real-mode boot Jan Beulich
2019-08-30 14:28 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecd28e008684e723bf9680419acba3b377206c94.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).