From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v3 1/3] x86: relax GDT check in arch_set_info_guest()
Date: Fri, 22 May 2020 16:14:54 +0200 [thread overview]
Message-ID: <ee21b6eb-cf34-74ee-ac73-33ff76fb07db@suse.com> (raw)
In-Reply-To: <58510f15-68d6-c773-5166-a38c72573442@citrix.com>
On 22.05.2020 15:27, Andrew Cooper wrote:
> On 20/05/2020 08:53, Jan Beulich wrote:
>> It is wrong for us to check frames beyond the guest specified limit
>> (in the compat case another loop bound is already correct).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> I'm still not overly convinced this is a good idea, because all it will
> allow people to do is write lazy code which breaks on older Xen.
Sounds a little like keeping bugs for the sake of keeping things
broken. The range of misbehaving versions could be shrunk by
backporting this change; I didn't intend to though, so far.
> However, if you still insist, Acked-by: Andrew Cooper
> <andrew.cooper3@citrix.com>
Thanks!
Jan
next prev parent reply other threads:[~2020-05-22 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 7:50 [PATCH v3 0/3] x86: XSA-298 follow-up Jan Beulich
2020-05-20 7:53 ` [PATCH v3 1/3] x86: relax GDT check in arch_set_info_guest() Jan Beulich
2020-05-20 10:20 ` Roger Pau Monné
2020-05-22 13:27 ` Andrew Cooper
2020-05-22 14:14 ` Jan Beulich [this message]
2020-05-20 7:54 ` [PATCH v3 2/3] x86: relax LDT " Jan Beulich
2020-05-20 7:54 ` [PATCH v3 3/3] x86/PV: polish pv_set_gdt() Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee21b6eb-cf34-74ee-ac73-33ff76fb07db@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).