xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] tools/init-xenstore-domain: fix description of --param
@ 2021-04-23 10:19 Olaf Hering
  2021-04-23 15:05 ` Juergen Gross
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2021-04-23 10:19 UTC (permalink / raw)
  To: xen-devel; +Cc: Olaf Hering, Ian Jackson, Wei Liu

The string is for the binary within the domain, not for the domain itself.

Fixes commit 83c365e6395f39c7ff91785b400682173d5e5d04

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 tools/helpers/init-xenstore-domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index 6836002f0b..8543a5efd6 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -58,7 +58,7 @@ static void usage(void)
 "  --memory <memory size>     size of the domain in MB, mandatory\n"
 "  --flask <flask-label>      optional flask label of the domain\n"
 "  --ramdisk <ramdisk-file>   optional ramdisk file for the domain\n"
-"  --param <cmdline>          optional additional parameters for the domain\n"
+"  --param <cmdline>          optional additional parameters for xenstored\n"
 "  --name <name>              name of the domain (default: Xenstore)\n"
 "  --maxmem <max size>        maximum memory size in the format:\n"
 "                             <MB val>|<a>/<b>|<MB val>:<a>/<b>\n"


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] tools/init-xenstore-domain: fix description of --param
  2021-04-23 10:19 [PATCH v1] tools/init-xenstore-domain: fix description of --param Olaf Hering
@ 2021-04-23 15:05 ` Juergen Gross
  0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2021-04-23 15:05 UTC (permalink / raw)
  To: Olaf Hering, xen-devel; +Cc: Ian Jackson, Wei Liu


[-- Attachment #1.1.1: Type: text/plain, Size: 495 bytes --]

On 23.04.21 12:19, Olaf Hering wrote:
> The string is for the binary within the domain, not for the domain itself.

Sorry, that is not true.

Just because the Mini-OS based xenstore stubdom doesn't need any other
parameters but the xenstore ones doesn't mean that this is true for all
possible xenstore domains.

The parameters passed via --params are just passed on to the domain.
How the domain is filtering out parameters not meant for xenstore is
not relevant here.


Juergen

[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-23 15:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 10:19 [PATCH v1] tools/init-xenstore-domain: fix description of --param Olaf Hering
2021-04-23 15:05 ` Juergen Gross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).