From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53179C433E0 for ; Fri, 29 May 2020 09:53:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AF7920776 for ; Fri, 29 May 2020 09:53:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AF7920776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jebhj-0004Oq-8d; Fri, 29 May 2020 09:53:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jebhi-0004Ol-P3 for xen-devel@lists.xenproject.org; Fri, 29 May 2020 09:53:30 +0000 X-Inumbo-ID: 3e972f12-a192-11ea-a884-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3e972f12-a192-11ea-a884-12813bfff9fa; Fri, 29 May 2020 09:53:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8744BAC85; Fri, 29 May 2020 09:53:26 +0000 (UTC) Subject: Re: [PATCH v10 07/12] xen: provide version information in hypfs To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= References: <20200519072106.26894-1-jgross@suse.com> <20200519072106.26894-8-jgross@suse.com> <88b80e61-3fb4-8f89-0597-d6959033478b@suse.com> <65af43c0-2ed4-4330-501f-d561468b7a0e@suse.com> From: Jan Beulich Message-ID: Date: Fri, 29 May 2020 11:53:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <65af43c0-2ed4-4330-501f-d561468b7a0e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Paul Durrant , Andrew Cooper , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 29.05.2020 11:19, Jürgen Groß wrote: > On 29.05.20 10:34, Jan Beulich wrote: >> On 19.05.2020 09:21, Juergen Gross wrote: >>> @@ -373,6 +374,52 @@ void __init do_initcalls(void) >>> (*call)(); >>> } >>> >>> +#ifdef CONFIG_HYPFS >>> +static unsigned int __read_mostly major_version; >>> +static unsigned int __read_mostly minor_version; >>> + >>> +static HYPFS_DIR_INIT(buildinfo, "buildinfo"); >>> +static HYPFS_DIR_INIT(compileinfo, "compileinfo"); >>> +static HYPFS_DIR_INIT(version, "version"); >>> +static HYPFS_UINT_INIT(major, "major", major_version); >>> +static HYPFS_UINT_INIT(minor, "minor", minor_version); >> >> These two lines fail to build with gcc 4.1 ("unknown field 'content' >> specified in initializer"), which I've deliberately tried as a last >> minute post-commit, pre-push check. I therefore reverted this change >> before pushing. >> >> Paul, Jürgen - please advise how to proceed, considering today's >> deadline. I'd accept pushing the rest of the series, if a fix for >> the issue will then still be permitted in later. Otherwise I'd have >> to wait for a fixed (incremental) version > > The attached patch should fix this problem (assuming the anonymous > union is to blame). > > Could you verify that, please? Reviewed-by: Jan Beulich Tested-by: Jan Beulich > In case the patch is fine, I'll resend the rest of the series with > that patch included, as there are adaptions in later patches needed. No need to, if you trust me to have made the right changes - I've also verified the rest of the series builds fine there. Jan