From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C177C433FE for ; Tue, 8 Dec 2020 16:50:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1221923A79 for ; Tue, 8 Dec 2020 16:50:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1221923A79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.47603.84247 (Exim 4.92) (envelope-from ) id 1kmgBS-000126-AD; Tue, 08 Dec 2020 16:49:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 47603.84247; Tue, 08 Dec 2020 16:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmgBS-00011z-79; Tue, 08 Dec 2020 16:49:50 +0000 Received: by outflank-mailman (input) for mailman id 47603; Tue, 08 Dec 2020 16:49:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmgBR-00011u-9d for xen-devel@lists.xenproject.org; Tue, 08 Dec 2020 16:49:49 +0000 Received: from mail-lj1-x243.google.com (unknown [2a00:1450:4864:20::243]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6825d8ee-764f-4837-ad14-19bda939b590; Tue, 08 Dec 2020 16:49:48 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id s11so11845898ljp.4 for ; Tue, 08 Dec 2020 08:49:48 -0800 (PST) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id n10sm1259603ljg.139.2020.12.08.08.49.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Dec 2020 08:49:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6825d8ee-764f-4837-ad14-19bda939b590 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=NW1ig4hO7jgwy54JnuoHax4nhf8RYyzgMtiDQuWg8VY=; b=DKMt6pgpw161wYD0sqSCEZ58f5rHMEBITXp4bpr73qLGCrZHX5qCfI5IBzH/KzNE9l fughebjVQkIArf5uKAspgedJLOa2KeUczS47gyiUCNzOEwh+3o85eQ2CJL54oPbQ6lvo 1r84r6DLAaFACX4dAJs5UfCt+6BXkh8+a3ozjnznk/Mv2gF7TOG86Mg6psL6g60X8dLi GbDSyDUaE9FummlO08s5jfolkEi6ikyHBTiG/IZos5lKSNEv4wOXXZ74/5sfXpmVhoVn w6OVA7SB0aKPq+E234eLzCuN1OMmkbPZgO1q2ri1IUNH8rTeE/79bztQLJvy5nItU8j7 2AQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NW1ig4hO7jgwy54JnuoHax4nhf8RYyzgMtiDQuWg8VY=; b=N5GCYHBjSSQ3LeddhsYUIKBBFSuvQV10w/aXW3JpV/nEEsUSO/GC7Vup8dfYTj5xvf VEWbYMMduIKpEomW2EhqwYzu8Cqi+nB6+oPK7W+bZfd3WY18cqmvALOS0VkOHKB06pbR bmzuaZPt6mSzm/DihC15Hyzl7OcZXEakOY36acjoD9VzK8TIOqVfGwL/LbLANwaz/muB nn455I5K04RtDpL9RgNxnjrhR++wrqBBXl1XKu2HY1bV8yLOvXUni+KZ/IWBHGQ9cy6p vH0PVND8zbz3Wlg1ueprifCtg4LrpbvNEpcn7JBgqs5HfTCYY35qPUl9Hde8ystOYvGz /b4A== X-Gm-Message-State: AOAM5334v9jacafTwDbTESWqEtkFduYKTzKzfdRtm6Zf1F27sM9zBHAK bWGkBTzsg3Hl1hZMYTCxN1XnuJwPHMmrYw== X-Google-Smtp-Source: ABdhPJyKXTWXrcLigOaVnRME3y7whjXqqsMKHnBJLVZdpn4c2xr+pO98rMtBIcGerZ0+Y4PST7yZ2g== X-Received: by 2002:a2e:9dcd:: with SMTP id x13mr11177952ljj.147.1607446187249; Tue, 08 Dec 2020 08:49:47 -0800 (PST) Subject: Re: [PATCH V3 20/23] xen/ioreq: Make x86's send_invalidate_req() common To: Jan Beulich Cc: Oleksandr Tyshchenko , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Paul Durrant , Julien Grall , xen-devel@lists.xenproject.org References: <1606732298-22107-1-git-send-email-olekstysh@gmail.com> <1606732298-22107-21-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: Date: Tue, 8 Dec 2020 18:49:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 08.12.20 17:24, Jan Beulich wrote: Hi Jan > On 30.11.2020 11:31, Oleksandr Tyshchenko wrote: >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -552,6 +552,8 @@ struct domain >> struct ioreq_server *server[MAX_NR_IOREQ_SERVERS]; >> unsigned int nr_servers; >> } ioreq_server; >> + >> + bool mapcache_invalidate; >> #endif >> }; > While I can see reasons to put this inside the #ifdef here, I > would suspect putting it in the hole next to the group of 5 > bools further up would be more efficient. ok, will put (although it will increase the number of #ifdef) -- Regards, Oleksandr Tyshchenko